From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Jakub Narebski <jnareb@gmail•com>
Cc: git@vger•kernel.org, gitster@pobox•com
Subject: Re: [PATCH v3] git-latexdiff: new command in contrib, to use latexdiff and Git
Date: Thu, 16 Feb 2012 15:15:27 +0100 [thread overview]
Message-ID: <vpq62f627b4.fsf@bauges.imag.fr> (raw)
In-Reply-To: <m3d39esxrg.fsf@localhost.localdomain> (Jakub Narebski's message of "Thu, 16 Feb 2012 05:40:26 -0800 (PST)")
Jakub Narebski <jnareb@gmail•com> writes:
> Nb. I think it would be good to put detecting PDF viewer in its own
> function, don't you?
I normally like functions, but for such a linear and small piece of
code, I think it adds more confusion that clarity to write
do_fo () {
actual stuff
}
do_foo
than the actual stuff alone.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2012-02-16 14:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 15:49 [PATCH] git-latexdiff: new command in contrib, to use latexdiff and Git Matthieu Moy
2012-02-15 23:33 ` Tim Haga
2012-02-16 8:34 ` Matthieu Moy
2012-02-16 8:39 ` [PATCH v2] " Matthieu Moy
2012-02-16 9:15 ` Jakub Narebski
2012-02-16 19:24 ` David Aguilar
2012-02-16 8:47 ` [PATCH] " Steven Michalske
2012-02-16 8:59 ` Matthieu Moy
2012-02-16 12:36 ` [PATCH v3] " Matthieu Moy
2012-02-16 13:40 ` Jakub Narebski
2012-02-16 14:08 ` [PATCH v4] " Matthieu Moy
2012-02-16 14:15 ` Matthieu Moy [this message]
2012-02-16 20:10 ` [PATCH] " Junio C Hamano
2012-02-16 21:04 ` Junio C Hamano
2012-02-17 8:10 ` Matthieu Moy
2012-02-17 13:31 ` Junio C Hamano
2012-02-17 14:19 ` Matthieu Moy
2012-02-17 17:25 ` Junio C Hamano
2012-02-17 18:40 ` Jakub Narebski
2012-02-20 8:50 ` Matthieu Moy
2012-02-20 9:05 ` Junio C Hamano
2012-02-20 12:00 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq62f627b4.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox