public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Clemens Buchacher <drizzd@aon•at>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] use persistent memory for rejected paths
Date: Mon, 15 Nov 2010 20:03:40 +0100	[thread overview]
Message-ID: <vpq62vymmsz.fsf@bauges.imag.fr> (raw)
In-Reply-To: <20101114130205.GA27560@localhost> (Clemens Buchacher's message of "Sun\, 14 Nov 2010 14\:02\:05 +0100")

Clemens Buchacher <drizzd@aon•at> writes:

> An aborted merge prints the list of rejected paths as part of the
> error message. Some of those paths do not have static buffers, so
> we have to keep a copy.

Like Junio, I'm surprised by this, but I guess you encountered the
problem.

> Use string_list's to accomplish this.

That seems to be a good thing anyway.

Did you remove all uses of "struct rejected_paths_list"? If so, you
can remove its declaration, if not, why?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  parent reply	other threads:[~2010-11-15 19:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 19:53 What's cooking in git.git (Nov 2010, #01; Tue, 9) Junio C Hamano
2010-11-09 20:11 ` Ævar Arnfjörð Bjarmason
2010-11-09 20:19 ` Matthieu Moy
2010-11-09 20:29   ` Drew Northup
2010-11-09 20:38 ` Jonathan Nieder
2010-11-09 21:38 ` Jakub Narebski
2010-11-11 17:21   ` Junio C Hamano
2010-11-11 23:53     ` Jakub Narebski
2010-11-09 21:46 ` Johan Herland
2010-11-09 22:11 ` Jeff King
2010-11-09 22:17 ` Erik Faye-Lund
2010-11-09 22:21   ` Ævar Arnfjörð Bjarmason
2010-11-09 22:25     ` Erik Faye-Lund
2010-11-09 22:27       ` Ævar Arnfjörð Bjarmason
2010-11-10 20:35   ` Yann Dirson
2010-11-11 12:26 ` Nguyen Thai Ngoc Duy
2010-11-11 14:28 ` Nguyen Thai Ngoc Duy
2010-11-14 13:02 ` [PATCH] use persistent memory for rejected paths Clemens Buchacher
2010-11-15 18:31   ` Junio C Hamano
2010-11-15 19:02     ` Clemens Buchacher
2010-11-15 19:03   ` Matthieu Moy [this message]
2010-11-15 19:41     ` Clemens Buchacher
2010-11-15 19:52       ` [PATCH v2] " Clemens Buchacher
2010-11-16 16:41         ` Matthieu Moy
2010-11-15 23:05       ` [PATCH] " Junio C Hamano
2010-11-15 23:30         ` Clemens Buchacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpq62vymmsz.fsf@bauges.imag.fr \
    --to=matthieu.moy@grenoble-inp$(echo .)fr \
    --cc=drizzd@aon$(echo .)at \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox