public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Eric Wong <e@80x24•org>
Cc: Samuel GROOT <samuel.groot@grenoble-inp•org>,
	git@vger•kernel.org, erwan.mathoniere@grenoble-inp•org,
	jordan.de-gea@grenoble-inp•org, gitster@pobox•com,
	aaron@schrab•com
Subject: Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop
Date: Sat, 28 May 2016 17:04:19 +0200	[thread overview]
Message-ID: <vpq8tyujkb0.fsf@anie.imag.fr> (raw)
In-Reply-To: <20160527201436.GA16547@dcvr.yhbt.net> (Eric Wong's message of "Fri, 27 May 2016 20:14:36 +0000")

Eric Wong <e@80x24•org> writes:

> Samuel GROOT <samuel.groot@grenoble-inp•org> wrote:
>
>>    (mbox) Adding cc: A<author@example•com>  from line 'Cc: A<author@example•com>, One<one@example•com>'
>>    (mbox) Adding cc: One<one@example•com>  from line 'Cc: A<author@example•com>, One<one@example•com>'
>> 
>> Though `git send-email` now outputs something like:
>> 
>>    (mbox) Adding cc: A<author@example•com>  from line 'Cc: A<author@example•com>'
>>    (mbox) Adding cc: One<one@example•com>  from line 'Cc: One<one@example•com>'
> I actually like neither, and would prefer something shorter:
>
>     (mbox) Adding cc: A <author@example•com> from Cc: header
>     (mbox) Adding cc: One <one@example•com> from Cc: header
>     (mbox) Adding cc: SoB <SoB@example•com> from Signed-off-by: trailer
>
> That way, there's no redundant addresses in each line and less
> likely to wrap.

I agree with this. Actually, I'd even say that the current output of
"git send-email" looks sloppy, and internal refactoring may be a good
opportunity to get it cleaner.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2016-05-28 15:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 14:01 [WIP-PATCH 0/2] send-email: refactor the email parser loop Samuel GROOT
2016-05-27 14:01 ` [WIP-PATCH 1/2] send-email: create email parser subroutine Samuel GROOT
2016-05-28 15:22   ` Matthieu Moy
2016-05-28 23:33     ` Eric Wong
2016-05-29 17:15       ` Samuel GROOT
2016-05-29 17:53         ` Matthieu Moy
2016-05-30 13:28           ` Samuel GROOT
2016-06-02 16:57       ` Samuel GROOT
2016-06-02 19:58         ` Eric Wong
2016-05-27 14:01 ` [WIP-PATCH 2/2] send-email: use refactored subroutine to parse patches Samuel GROOT
2016-05-27 20:14 ` [WIP-PATCH 0/2] send-email: refactor the email parser loop Eric Wong
2016-05-28 15:04   ` Matthieu Moy [this message]
2016-05-29 17:21     ` Samuel GROOT
2016-05-29 18:05       ` Matthieu Moy
2016-05-30 14:01         ` Samuel GROOT
2016-05-30 14:20           ` Matthieu Moy
2016-05-30 18:28             ` Samuel GROOT
2016-05-30 19:29               ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpq8tyujkb0.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp$(echo .)fr \
    --cc=aaron@schrab$(echo .)com \
    --cc=e@80x24$(echo .)org \
    --cc=erwan.mathoniere@grenoble-inp$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=jordan.de-gea@grenoble-inp$(echo .)org \
    --cc=samuel.groot@grenoble-inp$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox