From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH v5 3/7] change `git_config()` return value to void
Date: Thu, 31 Jul 2014 13:58:01 +0200 [thread overview]
Message-ID: <vpq8un9bv06.fsf@anie.imag.fr> (raw)
In-Reply-To: <53DA2E02.4000408@gmail.com> (Tanay Abhra's message of "Thu, 31 Jul 2014 17:22:34 +0530")
Tanay Abhra <tanayabh@gmail•com> writes:
> On 7/31/2014 4:52 PM, Matthieu Moy wrote:
>> Tanay Abhra <tanayabh@gmail•com> writes:
>>
>>> Signed-off-by: Tanay Abhra <tanayabh@gmail•com>
>>
>> I think I deserve a bit of credit here ;-).
>>
>
> Yes, but to show credit would I have to write "from you" or
> "signed-off-by"? :)
Original-patch-by: would be fine.
>> My bad, but this should be die(_("..."));, so that the message can be
>> translated. Not really serious since it's not really meant to be seen by
>> the user, though.
>>
>
> Noted. Though there are not many cases till I have read where error messages are marked
> for translation.
Yes, see my other message.
Overall, there are still many untranslated messages in Git's codebase:
$ git grep 'die(_("' | wc -l
517
$ git grep 'die("' | wc -l
1247
Part of the reason is that die() was written and used far before the
translation effort has started.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-31 11:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 9:44 [PATCH v5 0/7] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-31 9:44 ` [PATCH v5 1/7] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-31 9:44 ` [PATCH v5 2/7] add line number and file name info to `config_set` Tanay Abhra
2014-07-31 9:44 ` [PATCH v5 3/7] change `git_config()` return value to void Tanay Abhra
2014-07-31 11:22 ` Matthieu Moy
2014-07-31 11:32 ` Matthieu Moy
2014-07-31 11:52 ` Tanay Abhra
2014-07-31 11:58 ` Matthieu Moy [this message]
2014-07-31 9:44 ` [PATCH v5 4/7] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-31 11:28 ` Matthieu Moy
2014-07-31 9:44 ` [PATCH v5 5/7] add a test for semantic errors in config files Tanay Abhra
2014-07-31 9:44 ` [PATCH 6/7] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-31 11:30 ` Matthieu Moy
2014-07-31 9:44 ` [PATCH 7/7] add tests for `git_config_get_string_const()` Tanay Abhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq8un9bv06.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox