Subject: Re: [PATCH 3/3] rebase: turn git-rebase--*.sh into separate programs

From: Matthieu Moy <[email-masked]>
Date: Wed, 17 Feb 2016 15:05:18 +0100

Nguyễn Thái Ngọc Duy <[email-masked]> writes:

> +	git_quiet=$GIT_QUIET
> +	git_reflog_action=$GIT_REFLOG_ACTION
> +	export GIT_PAGER
> +	# these are for write_basic_state()
> +	export allow_rerere_autoupdate gpg_sign_opt head_name onto
> +	export orig_head state_dir strategy strategy_opts verbose
> +	# common variables
> +	export action git_reflog_action git_quiet keep_empty
> +	export rebase_root restrict_revision revisions upstream
> +	# git-rebase--am specific
> +	export git_am_opt
> +	# git-rebase--interactive specific
> +	export autosquash cmd force_rebase onto_name preserve_merges
> +	export squash_onto switch_to
> +
> +	exec git-rebase--$type

This is a good first step, but we may later want to turn these
environment variables into command-line options for the helpers. Or not.

On overall, the series looks good to me, but I don't have time for a
detailed review.

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/