From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: "Rainer M. Canavan" <git@canavan•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] In configure.ac, try -lpthread in $LIBS instead of $CFLAGS to make picky linkers happy
Date: Fri, 06 Nov 2015 09:25:20 +0100 [thread overview]
Message-ID: <vpqbnb7edqn.fsf@anie.imag.fr> (raw)
In-Reply-To: <201511060111.tA61BbFX084361@tezro.nonet> (Rainer M. Canavan's message of "Fri, 6 Nov 2015 02:11:37 +0100 (CET)")
"Rainer M. Canavan" <git@canavan•de> writes:
> Subject: Re: [PATCH] In configure.ac, try -lpthread in $LIBS instead of $CFLAGS to make picky linkers happy
The patch looks good, but the subject should be improved. We normally
try to stick to 50 characters (to let "git log --oneline" fit in a 80
columns terminal). 50 is a bit strict and not always followed, but yours
is definitely too long.
Also, the convention is "subsystem: what you did". I'd suggest this:
configure.ac: try -lpthread in $LIBS instead of $CFLAGS
The "to make picky linkers happy" is important, but redundant with the
body of the message.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-11-06 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 22:30 configure: -lpthread doesn't belong in CFLAGS Rainer M. Canavan
2015-11-02 8:27 ` Matthieu Moy
2015-11-06 1:11 ` [PATCH] In configure.ac, try -lpthread in $LIBS instead of $CFLAGS to make picky linkers happy Rainer M. Canavan
2015-11-06 8:25 ` Matthieu Moy [this message]
2015-11-08 15:28 ` [PATCH] configure.ac: try -lpthread in $LIBS instead of $CFLAGS Rainer M. Canavan
2015-11-08 16:00 ` Matthieu Moy
2015-11-20 11:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqbnb7edqn.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@canavan$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox