Subject: Re: [PUB]What's cooking in git.git (Jul 2015, #01; Wed, 1)

From: Matthieu Moy <[email-masked]>
Date: Thu, 02 Jul 2015 11:33:12 +0200

Junio C Hamano <[email-masked]> writes:

> * ad/bisect-terms (2015-06-29) 10 commits
>  - bisect: allow setting any user-specified in 'git bisect start'
>  - bisect: add 'git bisect terms' to view the current terms
>  - bisect: add the terms old/new
>  - bisect: sanity check on terms
>  - bisect: don't mix option parsing and non-trivial code
>  - bisect: simplify the addition of new bisect terms
>  - bisect: replace hardcoded "bad|good" by variables
>  - Documentation/bisect: revise overall content
>  - Documentation/bisect: move getting help section to the end
>  - bisect: correction of typo
>
>  The use of 'good/bad' in "git bisect" made it confusing to use when
>  hunting for a state change that is not a regression (e.g. bugfix).
>  The command learned 'old/new' and then allows the end user to
>  say e.g. "bisect start --term-old=fast --term=new=slow" to find a
>  performance regression.
>
>  The bottom part has been quite well cooked.  Perhaps split it into
>  two topisc and merge the earlier ones to 'next' before the rest
>  settles.  Michael's idea to make 'good/bad' more intelligent does
>  have certain attractiveness ($gname/272867).

I think it makes sense to merge the first patches soon:

 - bisect: don't mix option parsing and non-trivial code
 - bisect: simplify the addition of new bisect terms
 - bisect: replace hardcoded "bad|good" by variables
 - Documentation/bisect: revise overall content
 - Documentation/bisect: move getting help section to the end
 - bisect: correction of typo

I have nothing to add on the last ones, but they can cook in pu a bit
longer.

Do you expect anything from my side?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/