From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Remi Lespinet <remi.lespinet@ensimag•grenoble-inp.fr>
Cc: git@vger•kernel.org,
Remi Galan <remi.galan-alfonso@ensimag•grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag•grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag•grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>,
Jorge Juan Garcia Garcia
<Jorge-Juan.Garcia-Garcia@ensimag•imag.fr>,
Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag•imag.fr>
Subject: Re: [PATCH/RFC] send-email: allow multiple emails using --cc --to and --bcc
Date: Thu, 28 May 2015 13:47:21 +0200 [thread overview]
Message-ID: <vpqd21kvs8m.fsf@anie.imag.fr> (raw)
In-Reply-To: <1432809733-4321-2-git-send-email-remi.lespinet@ensimag.grenoble-inp.fr> (Remi Lespinet's message of "Thu, 28 May 2015 12:42:13 +0200")
Remi Lespinet <remi.lespinet@ensimag•grenoble-inp.fr> writes:
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -519,6 +519,12 @@ Result: OK
> EOF
> "
>
> +replace_variable_fields () {
> + sed -e "s/^\(Date:\).*/\1 DATE-STRING/" \
> + -e "s/^\(Message-Id:\).*/\1 MESSAGE-ID-STRING/" \
> + -e "s/^\(X-Mailer:\).*/\1 X-MAILER-STRING/"
> +}
> +
> test_suppression () {
> git send-email \
> --dry-run \
> @@ -526,10 +532,7 @@ test_suppression () {
> --from="Example <from@example•com>" \
> --to=to@example•com \
> --smtp-server relay.example.com \
> - $patches |
> - sed -e "s/^\(Date:\).*/\1 DATE-STRING/" \
> - -e "s/^\(Message-Id:\).*/\1 MESSAGE-ID-STRING/" \
> - -e "s/^\(X-Mailer:\).*/\1 X-MAILER-STRING/" \
> + $patches | replace_variable_fields \
I wouldn't insist on that, but this change would be better done in a
separate, preparatory patch (that would be PATCH 1/2, and the actual
code would be PATCH 2/2).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-05-28 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 10:42 [PATCH/RFC] send-email: allow multiple emails using --cc --to and --bcc Remi Lespinet
2015-05-28 10:42 ` Remi Lespinet
2015-05-28 11:47 ` Matthieu Moy [this message]
2015-05-28 15:26 ` Eric Sunshine
2015-05-28 18:02 ` Eric Sunshine
2015-05-29 16:07 ` Remi LESPINET
2015-05-28 17:45 ` Junio C Hamano
2015-05-29 16:05 ` Remi LESPINET
2015-05-29 16:13 ` Junio C Hamano
2015-05-29 17:55 ` Matthieu Moy
2015-05-29 18:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqd21kvs8m.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=Jorge-Juan.Garcia-Garcia@ensimag$(echo .)imag.fr \
--cc=Mathieu.Lienard--Mayor@ensimag$(echo .)imag.fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=git@vger$(echo .)kernel.org \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox