From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Andrei Dinu <mandrei.dinu@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v4 1/2] diff-no-index.c: rename read_directory()
Date: Wed, 19 Mar 2014 18:47:08 +0100 [thread overview]
Message-ID: <vpqd2hidqsj.fsf@anie.imag.fr> (raw)
In-Reply-To: <1395243516-5753-1-git-send-email-mandrei.dinu@gmail.com> (Andrei Dinu's message of "Wed, 19 Mar 2014 17:38:35 +0200")
Andrei Dinu <mandrei.dinu@gmail•com> writes:
> Signed-off-by: Andrei Dinu <mandrei.dinu@gmail•com>
The commit message should explain why this is a good change. In general,
the "why?" question is more important than the "what" (the reader can
see from the patch that you renamed the function, but cannot guess why
you did so).
Also, when sending multiple patches, send them as a single thread. See
for example:
http://thread.gmane.org/gmane.comp.version-control.git/244441
In practice, call "git send-email" once, not once per patch. Try sending
the patches to yourself first to avoid disturbing the list in case of
user error.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2014-03-19 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 15:38 [PATCH v4 1/2] diff-no-index.c: rename read_directory() Andrei Dinu
2014-03-19 17:47 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqd2hidqsj.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=mandrei.dinu@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox