From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Lars R. Damerow" <lars@pixar•com>,
Linus Torvalds <torvalds@linux-foundation•org>,
Jeff King <peff@peff•net>,
Erik Faye-Lund <kusmabite@googlemail•com>,
git@vger•kernel.org
Subject: Re: [PATCH] Rename ONE_FILESYSTEM to DISCOVERY_ACROSS_FILESYSTEM
Date: Mon, 05 Apr 2010 00:37:37 +0200 [thread overview]
Message-ID: <vpqd3ye26a6.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vzl1iyhof.fsf_-_@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun\, 04 Apr 2010 15\:30\:24 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> If a missing ONE_FILESYSTEM defaults to true, the only users who set this
> variable set it to false to tell git not to limit the discovery to one
> filesystem; there are too many negations in one sentence to make a simple
> panda brain dizzy.
Right.
+ an explicit respository directory set via 'GIT_DIR' or on the
While you're there, you can spell respository as "repository" ;-).
> diff --git a/setup.c b/setup.c
> index d290633..5a26b5b 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -392,7 +392,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
> * etc.
> */
> offset = len = strlen(cwd);
> - one_filesystem = git_env_bool("GIT_ONE_FILESYSTEM", 0);
> + one_filesystem = !git_env_bool("GIT_DISCOVERY_ACROSS_FILESYSTEM", 0);
> if (one_filesystem) {
> if (stat(".", &buf))
> die_errno("failed to stat '.'");
I guess you still have one instance of GIT_ONE_FILESYSTEM a little
below in the error message:
"Stopping at filesystem boundary since GIT_ONE_FILESYSTEM is true."
which should become
"Stopping at filesystem boundary since GIT_DISCOVERY_ACROSS_FILESYSTEM\n"
"is not set."
or so.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-04-04 22:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 19:55 [PATCH v3 0/3] Add support for GIT_ONE_FILESYSTEM Lars R. Damerow
2010-03-17 19:55 ` [PATCH 1/3] config.c: remove static keyword from git_env_bool() Lars R. Damerow
2010-03-17 19:55 ` [PATCH 2/3] truncate cwd string before printing error message Lars R. Damerow
2010-03-17 19:55 ` [PATCH 3/3] Add support for GIT_ONE_FILESYSTEM Lars R. Damerow
2010-03-28 9:22 ` Jeff King
2010-03-28 12:05 ` Jeff King
2010-03-28 16:44 ` Junio C Hamano
2010-03-28 17:32 ` Lars Damerow
2010-03-30 15:58 ` Jeff King
2010-03-30 22:43 ` Linus Torvalds
2010-03-30 22:59 ` Thomas Rast
2010-03-30 23:04 ` Jeff King
2010-03-30 23:02 ` Jeff King
2010-03-30 23:10 ` Junio C Hamano
2010-03-30 23:12 ` Linus Torvalds
2010-03-31 0:54 ` Erik Faye-Lund
2010-04-04 18:00 ` [PATCH] GIT_ONE_FILESYSTEM: flip the default to stop at filesystem boundaries Junio C Hamano
2010-04-04 22:30 ` [PATCH] Rename ONE_FILESYSTEM to DISCOVERY_ACROSS_FILESYSTEM Junio C Hamano
2010-04-04 22:37 ` Matthieu Moy [this message]
2010-04-04 22:39 ` [PATCH] GIT_ONE_FILESYSTEM: flip the default to stop at filesystem boundaries Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqd3ye26a6.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=kusmabite@googlemail$(echo .)com \
--cc=lars@pixar$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox