From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Junio C Hamano <gitster@pobox•com>
Cc: Erwan Mathoniere <erwan.mathoniere@grenoble-inp•org>,
git@vger•kernel.org, jordan.de-gea@grenoble-inp•org,
samuel.groot@grenoble-inp•org, tom.russello@grenoble-inp•org
Subject: Re: [RFC/PATCH v2] pull: add --set-upstream
Date: Tue, 07 Jun 2016 09:06:18 +0200 [thread overview]
Message-ID: <vpqeg89bhqt.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqqoa7ew319.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 06 Jun 2016 12:06:10 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
>
>>> +test_config_unchanged () {
>>> + git config --list --local >original
>>> + "$@"
>>> + git config --list --local >modified
>>> + test_cmp original modified
>>> +}
>>
>> The test passes if "$@" fails. You should &&-chain the lines here to
>> catch things like crashes or unexpected "exit 1" in git.
>
> That is true, but allowing "$@" failure may be deliberate.
I don't think so:
+test_expect_success 'pull -u should not work when merging unrelated histories' '
+ git checkout master &&
+ test_config_unchanged test_must_fail git pull -u step_parent master
+'
;-)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-06-07 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 15:25 [RFC/PATCH] pull: set-upstream implementation Erwan Mathoniere
2016-05-25 18:09 ` Junio C Hamano
2016-05-29 20:00 ` Erwan Mathoniere
2016-06-06 9:34 ` [RFC/PATCH v2] pull: add --set-upstream Erwan Mathoniere
2016-06-06 15:54 ` Matthieu Moy
2016-06-06 19:06 ` Junio C Hamano
2016-06-07 7:06 ` Matthieu Moy [this message]
2016-06-07 12:54 ` Erwan Mathoniere
2016-06-07 13:15 ` Erwan Mathoniere
2016-06-07 12:43 ` Erwan Mathoniere
2016-06-06 16:29 ` Philip Oakley
2016-06-07 13:42 ` Erwan Mathoniere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqeg89bhqt.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=erwan.mathoniere@grenoble-inp$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jordan.de-gea@grenoble-inp$(echo .)org \
--cc=samuel.groot@grenoble-inp$(echo .)org \
--cc=tom.russello@grenoble-inp$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox