From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>, Jeff King <peff@peff•net>,
git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH v2 2/2] make config --add behave correctly for empty and NULL values
Date: Fri, 12 Sep 2014 10:15:14 +0200 [thread overview]
Message-ID: <vpqegvhfe5p.fsf@anie.imag.fr> (raw)
In-Reply-To: <54129FE1.6020303@gmail.com> (Tanay Abhra's message of "Fri, 12 Sep 2014 12:55:21 +0530")
Tanay Abhra <tanayabh@gmail•com> writes:
> +const char CONFIG_REGEX_NONE[] = "a^";
I have a slight preference for this version (no magic (void *)1 value,
and belts-and-suspenders solution since someone actually using the regex
should still get a correct behavior.
But I'm fine with both Junio/Peff's version or this one.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-09-12 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 10:17 [PATCH] make config --add behave correctly for empty and NULL values Tanay Abhra
2014-08-18 12:33 ` Matthieu Moy
2014-08-18 18:18 ` Junio C Hamano
2014-08-19 5:17 ` Jeff King
2014-08-19 6:03 ` Junio C Hamano
2014-08-19 6:20 ` Jeff King
2014-09-11 23:35 ` Junio C Hamano
2014-09-12 2:29 ` Jeff King
2014-09-12 7:23 ` [PATCH v2 1/2] document irregular config --add behaviour " Tanay Abhra
2014-09-12 7:25 ` [PATCH v2 2/2] make config --add behave correctly " Tanay Abhra
2014-09-12 8:15 ` Matthieu Moy [this message]
2014-09-12 17:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqegvhfe5p.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox