From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH 5/7] enforce `xfuncname` precedence over `funcname`
Date: Thu, 24 Jul 2014 20:47:45 +0200 [thread overview]
Message-ID: <vpqegxa386m.fsf@anie.imag.fr> (raw)
In-Reply-To: <53D15188.2010209@gmail.com> (Tanay Abhra's message of "Fri, 25 Jul 2014 00:03:44 +0530")
Tanay Abhra <tanayabh@gmail•com> writes:
> For core the only test failing was xfuncname vs funcname,
Being a little pessimistic: there may be other cases where the hashtable
magically gives the right order for existing tests, but that would fail
for untested use-cases.
But I can't think of any such case.
> so the situation is not as bad as you think. One course of action
> would be leave git_config() as it is, so that third party apps
> may not be broken. Provide a function like git_config_cache(),
> then rename all the git_config() calls in core to git_config_cache(),
> fallback to git_config() where it is not applicable (for example,
> git config -l).
I think Junio's point about "git config -l" is correct: we should just
keep git_config_raw there.
OTOH, renaming git_config to git_config_cache seems a lot of code churn,
so I'd keep the name git_config. Perhaps git_config_raw is no longer a
good name and it could be called git_config_ordered.
If we keep one call to git_config_raw there, then maybe we can use it
for xfuncname/funcname too, and keep the behavior unchanged.
> Also can you name any third party apps that use the git_config()
> system on which I can test the patches.
There are probably tons of. I can think of git-multimail.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-24 18:48 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 18:42 [PATCH 0/7] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-23 18:42 ` [PATCH 1/7] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-23 21:49 ` Junio C Hamano
2014-07-24 13:33 ` Tanay Abhra
2014-07-24 18:31 ` Junio C Hamano
2014-07-24 18:40 ` Tanay Abhra
2014-07-24 18:49 ` Matthieu Moy
2014-07-23 18:42 ` [PATCH 2/7] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-23 19:55 ` Matthieu Moy
2014-07-23 19:58 ` Matthieu Moy
2014-07-23 21:58 ` Junio C Hamano
2014-07-24 6:43 ` Matthieu Moy
2014-07-23 18:42 ` [PATCH 3/7] add a test for semantic errors in config files Tanay Abhra
2014-07-23 19:55 ` Matthieu Moy
2014-07-23 22:11 ` Junio C Hamano
2014-07-24 13:56 ` Tanay Abhra
2014-07-24 14:05 ` Matthieu Moy
2014-07-24 16:41 ` Junio C Hamano
2014-07-23 18:42 ` [PATCH 4/7] add line number and file name info to `config_set` Tanay Abhra
2014-07-23 22:24 ` Junio C Hamano
2014-07-23 18:42 ` [PATCH 5/7] enforce `xfuncname` precedence over `funcname` Tanay Abhra
2014-07-23 20:05 ` Matthieu Moy
2014-07-23 21:04 ` Eric Sunshine
2014-07-23 22:34 ` Junio C Hamano
2014-07-24 6:39 ` Matthieu Moy
2014-07-24 17:09 ` Junio C Hamano
2014-07-24 18:33 ` Tanay Abhra
2014-07-24 18:47 ` Matthieu Moy [this message]
2014-07-24 19:04 ` John Keeping
2014-07-24 19:20 ` Junio C Hamano
2014-07-24 19:29 ` Tanay Abhra
2014-07-24 19:54 ` Junio C Hamano
2014-07-24 21:22 ` Ramsay Jones
2014-07-25 3:16 ` Tanay Abhra
2014-07-25 6:54 ` Matthieu Moy
2014-07-25 17:09 ` Junio C Hamano
2014-07-25 17:45 ` Matthieu Moy
2014-07-25 18:55 ` Junio C Hamano
2014-07-23 18:42 ` [PATCH 6/7] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-23 18:42 ` [PATCH 7/7] Add tests for `git_config_get_string()` Tanay Abhra
2014-07-23 20:08 ` Matthieu Moy
2014-07-23 19:38 ` [PATCH 0/7] Rewrite `git_config()` using config-set API Matthieu Moy
2014-07-23 21:44 ` Junio C Hamano
2014-07-24 15:04 ` Tanay Abhra
2014-07-24 15:39 ` Matthieu Moy
2014-07-24 15:59 ` Tanay Abhra
2014-07-24 16:17 ` Matthieu Moy
2014-07-24 20:03 ` Junio C Hamano
2014-07-24 15:06 ` [PATCH v12 1/2] add `config_set` API for caching config-like files Tanay Abhra
2014-07-24 18:41 ` Junio C Hamano
2014-07-24 15:09 ` [PATCH v12 2/2] test-config: add tests for the config_set API Tanay Abhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqegxa386m.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox