From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [RFC/PATCH v2 2/2] config: Add new query functions to the api docs
Date: Tue, 03 Jun 2014 17:35:33 +0200 [thread overview]
Message-ID: <vpqegz6qa4a.fsf@anie.imag.fr> (raw)
In-Reply-To: <1401720460-6525-3-git-send-email-tanayabh@gmail.com> (Tanay Abhra's message of "Mon, 2 Jun 2014 07:47:40 -0700")
Tanay Abhra <tanayabh@gmail•com> writes:
> Add explanations for `git_config_get_string_multi` and `git_config_get_string`
> which utilize the config hash table for querying in a non-callback manner for
> a specific variable.
I'd squash this into the previous patch: the reader appreciates having
the documentation when reviewing the code itself (so that one can check
that the documented behavior matches the implementation).
> +the highest priority(i.e. value in the repo config will be preferred over
Missing space before (.
Other than that, this seems good.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2014-06-03 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:47 [RFC/PATCH v2 0/2] Git config cache & special querying api utilizing the cache Tanay Abhra
2014-06-02 14:47 ` [RFC/PATCH v2 1/2] config: Add hashtable for config parsing & retrieval Tanay Abhra
2014-06-02 19:33 ` Torsten Bögershausen
2014-06-03 7:58 ` Jeff King
2014-06-09 8:17 ` Eric Sunshine
2014-06-02 14:47 ` [RFC/PATCH v2 2/2] config: Add new query functions to the api docs Tanay Abhra
2014-06-03 15:35 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqegz6qa4a.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox