Subject: Re: [PATCH v4 1/8] branch: refactor width computation

From: Matthieu Moy <[email-masked]>
Date: Sun, 13 Sep 2015 13:51:53 +0200

Karthik Nayak <[email-masked]> writes:

> @@ -667,26 +675,22 @@ static int print_ref_list(int kinds, int detached, int verbose, int abbrev, stru
>  			clear_commit_marks(item->commit, ALL_REV_FLAGS);
>  		}
>  		clear_commit_marks(filter, ALL_REV_FLAGS);
> -
> -		if (verbose)
> -			ref_list.maxwidth = calc_maxwidth(&ref_list);
>  	}
> +	if (verbose)
> +		maxwidth = calc_maxwidth(&ref_list, strlen(remote_prefix));

I don't understand this hunk. To give a bit more context, the closing
brace corresponds to:

	if (merge_filter != NO_FILTER) {

Hence this patch gets the two lines out of this "if". Actually, I don't
understand how it could work previously. Wasn't this "calc_maxwidth"
needed regardless of merge_filter from the beginning?

In any case, that remark is not an objection on your patch, but I'd like
to understand.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/