From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH v4 0/5] git_config callers rewritten with the new config cache API
Date: Wed, 30 Jul 2014 18:45:08 +0200 [thread overview]
Message-ID: <vpqiomeokx7.fsf@anie.imag.fr> (raw)
In-Reply-To: <53D8FB39.7040904@gmail.com> (Tanay Abhra's message of "Wed, 30 Jul 2014 19:33:37 +0530")
Tanay Abhra <tanayabh@gmail•com> writes:
> Yes you are right, there is a call to git_die_config() also in the series. I will add
> the info in the next reroll.
If unsure, rebase your branch locally on the commit on which it is meant
to apply, and check that it works for you.
> Also, any thoughts on what to do with git_default_config()? We can,
>
> 1> make a new function git_load_default_config(), use it for the rewrites.
That seems the most sensible option. It could be called it git.c before
the command-dependant part, so that any call to git loads this.
I didn't check if it was correct (e.g. do some command rely on the fact
that the default config is not loaded?)
> 2> git_default_config() is rewritten to be loaded only once even if it is called
> again and again during the process run, so that we use the same function in callbacks
> and in the new API using rewrites.
Seems like a workaround, and to me the point of your GSoC is to make the
code cleaner, hence avoid workaraounds ...
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-30 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 13:39 [PATCH v4 0/5] git_config callers rewritten with the new config cache API Tanay Abhra
2014-07-30 13:39 ` [PATCH v4 1/5] pager.c: replace `git_config()` with `git_config_get_value()` Tanay Abhra
2014-07-30 13:39 ` [PATCH v4 2/5] notes.c: replace `git_config()` with `git_config_get_value_multi()` Tanay Abhra
2014-07-30 14:13 ` Matthieu Moy
2014-07-30 14:40 ` Tanay Abhra
2014-07-30 16:42 ` Matthieu Moy
2014-07-31 11:38 ` Matthieu Moy
2014-07-31 12:13 ` Tanay Abhra
2014-07-30 13:39 ` [PATCH v4 3/5] imap-send.c: replace `git_config()` with `git_config_get_*()` family Tanay Abhra
2014-07-30 13:39 ` [PATCH v4 4/5] branch.c: replace `git_config()` with `git_config_get_string() Tanay Abhra
2014-07-30 16:23 ` Matthieu Moy
2014-07-30 13:39 ` [PATCH v4 5/5] alias.c: replace `git_config()` with `git_config_get_string()` Tanay Abhra
2014-07-30 13:46 ` [PATCH v4 0/5] git_config callers rewritten with the new config cache API Matthieu Moy
2014-07-30 14:03 ` Tanay Abhra
2014-07-30 16:45 ` Matthieu Moy [this message]
2014-07-31 11:37 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqiomeokx7.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox