Subject: Re: [RFC PATCH v2 1/2] Makefile: add check-headers target

From: Matthieu Moy <[email-masked]>
Date: Wed, 10 Sep 2014 19:24:50 +0200

Junio C Hamano <[email-masked]> writes:

> David Aguilar <[email-masked]> writes:
>
>> On Mon, Sep 08, 2014 at 12:57:46PM -0700, Junio C Hamano wrote:
>>> Matthieu Moy <[email-masked]> writes:
>>> ...
>>> > for header in .h ewah/*.h vcs-svn/*.h xdiff/*.h
>>> > do
>>> > 	...
>>> > done
>>> 
>>> Yes, that would be even better.  Then you wouldn't even have to
>>> worry about $IFS dance.
>>
>> The original motivation was to avoid picking up the generated
>> common-cmds.h header file.
>
> 	for header
>         do
>         	case "$header" in $exceptions) continue ;; esac
> 		...
> 	done
>
> with comments describing why these exceptions are made would be a
> better way to go in such a case.

+1 from me. It would allow developers to use the rule without "git
add"-ing new .h files, and the comment would document why the
exceptions are there (which missed in the original patch IMHO).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/