From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Elia Pinto <gitter.spiros@gmail•com>,
"git\@vger.kernel.org" <git@vger•kernel.org>,
Eric Sunshine <sunshine@sunshineco•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: Patch Series v3 for "use the $( ... ) construct for command substitution"
Date: Fri, 04 Apr 2014 19:40:35 +0200 [thread overview]
Message-ID: <vpqk3b56lik.fsf@anie.imag.fr> (raw)
In-Reply-To: <20140404172946.GI6851@google.com> (Jonathan Nieder's message of "Fri, 4 Apr 2014 10:29:46 -0700")
Jonathan Nieder <jrnieder@gmail•com> writes:
> If the script is "obviously correct" enough then there is no need
> to manually go through 140 files after that point.
The script cannot be "obviously correct", as there are a lot of
potential corner-cases (nested `, nesting ` within ", comments, ...).
> If the only way to get this done is to actually manually review those
> 140 files, I just don't think it's worth it.
Honnestly, I went through the series once and it wasn't that painful. I
need to do a more carefull review, but using "git diff --color-words=."
it can be really fast.
Junio suggested splitting the series into batches of around 10 patches,
sending one per week, but that would make too many patches IMHO (14
weeks ...).
I'd suggest doing a first batch with only scripts that are not tests and
pushing this to git.git. Then the remaining series will be a bit less
scary.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-04-04 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 16:52 Patch Series v3 for "use the $( ... ) construct for command substitution" Elia Pinto
2014-04-04 17:29 ` Jonathan Nieder
2014-04-04 17:40 ` Matthieu Moy [this message]
2014-04-04 18:12 ` Jonathan Nieder
2014-04-04 19:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqk3b56lik.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=gitter.spiros@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox