From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Paul Tan <pyokagan@gmail•com>
Cc: git@vger•kernel.org, Stefan Beller <sbeller@google•com>,
Johannes Schindelin <johannes.schindelin@gmx•de>,
Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH 2/2] pull: handle --log=<n>
Date: Wed, 13 May 2015 11:38:47 +0200 [thread overview]
Message-ID: <vpqlhgszujc.fsf@anie.imag.fr> (raw)
In-Reply-To: <1431508661-21729-3-git-send-email-pyokagan@gmail.com> (Paul Tan's message of "Wed, 13 May 2015 17:17:41 +0800")
Paul Tan <pyokagan@gmail•com> writes:
> - --log|--no-log)
> - log_arg=$1 ;;
> + --log|--log=*|--no-log)
> + log_arg="$1" ;;
I think you actually don't need the double quotes here (var=$value works
even if $value has spaces IIRC), but they don't harm and I prefer having
them.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-05-13 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 9:17 [PATCH 0/2] teach git pull to handle --log=<n> Paul Tan
2015-05-13 9:17 ` [PATCH 1/2] t5524: test --log=1 limits shortlog length Paul Tan
2015-05-13 9:17 ` [PATCH 2/2] pull: handle --log=<n> Paul Tan
2015-05-13 9:38 ` Matthieu Moy [this message]
2015-05-13 12:23 ` Johannes Schindelin
2015-05-13 20:03 ` Matthieu Moy
2015-05-13 9:40 ` [PATCH 0/2] teach git pull to " Matthieu Moy
2015-05-14 17:11 ` Junio C Hamano
2015-05-15 11:15 ` Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqlhgszujc.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=pyokagan@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox