From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: pascal@obry•net
Cc: git list <git@vger•kernel.org>
Subject: Re: [PATCH v4] Do not decode url protocol.
Date: Tue, 22 Jun 2010 23:39:46 +0200 [thread overview]
Message-ID: <vpqmxumu4pp.fsf@bauges.imag.fr> (raw)
In-Reply-To: <4C211A39.2080207@obry.net> (Pascal Obry's message of "Tue\, 22 Jun 2010 22\:16\:57 +0200")
Pascal Obry <pascal.obry@gmail•com> writes:
> When using the protocol git+ssh:// for example we do not want to
> decode the '+' as a space. The url decoding must take place only
> for the server name and parameters.
>
> This fixes a regression introduced in 9d2e942.
> ---
> url.c | 19 +++++++++++++++----
> 1 files changed, 15 insertions(+), 4 deletions(-)
>
> Ok, so this is the fourth version of this patch. Thanks again Matthieu
> for the review. I think this time I got the place for the message
> right :)
Hmm, what's so unclear in "between the --- (tripple) and the
diffstat." ;-) ? (especially the "between" part)
> + /* Skip protocol if present. */
> + if (with_protocol) {
> + first_slash = strchr(*query, '/');
> +
> + while (q < first_slash)
> + strbuf_addch(&out, *q++);
> + }
Nothing personal, but you messed up indentation. Git indents with tabs
(8 chars width), not 2 spaces.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-06-22 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 20:16 [PATCH v4] Do not decode url protocol Pascal Obry
2010-06-22 21:39 ` Matthieu Moy [this message]
2010-06-22 22:46 ` Jeff King
2010-06-23 17:27 ` Junio C Hamano
2010-06-23 17:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqmxumu4pp.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=pascal@obry$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox