From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
Christian Couder <christian.couder@gmail•com>
Subject: Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line
Date: Thu, 07 Apr 2016 19:35:27 +0200 [thread overview]
Message-ID: <vpqoa9ltj8g.fsf@anie.imag.fr> (raw)
In-Reply-To: <1460042563-32741-3-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 7 Apr 2016 18:23:10 +0300")
"Michael S. Tsirkin" <mst@redhat•com> writes:
> it's sometimes useful to be able to pass output message of
> git-mailinfo through git-interpret-trailers,
> but that creates problems since that does not
> include the subject and an empty line after that,
> making interpret-trailers add an empty line.
Nit: we usually wrap our text around 72 columns in the commit message.
Yours is wrapped weirdly.
> Add a flag to bypass adding the blank line.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat•com>
> ---
> trailer.h | 2 +-
> builtin/interpret-trailers.c | 9 +++++++--
> trailer.c | 10 +++++++---
> 3 files changed, 15 insertions(+), 6 deletions(-)
You'd definitely need some tests and documentation if you introduce a
new option.
No time for a real review, sorry.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-04-07 17:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:23 [PATCH 0/4] git-am: use trailers to add extra signatures Michael S. Tsirkin
2016-04-07 15:23 ` [PATCH 1/4] builtin/interpret-trailers.c: allow -t Michael S. Tsirkin
2016-04-07 16:55 ` Junio C Hamano
2016-04-07 17:17 ` Matthieu Moy
2016-04-07 17:26 ` Junio C Hamano
2016-04-07 17:30 ` Michael S. Tsirkin
2016-04-07 17:28 ` Michael S. Tsirkin
2016-04-07 17:30 ` Junio C Hamano
2016-04-07 17:52 ` Michael S. Tsirkin
2016-04-07 17:56 ` Junio C Hamano
2016-04-07 15:23 ` [PATCH 2/4] builtin/interpret-trailers: suppress blank line Michael S. Tsirkin
2016-04-07 17:00 ` Junio C Hamano
2016-04-07 17:21 ` Junio C Hamano
2016-04-07 17:21 ` Michael S. Tsirkin
2016-04-07 17:34 ` Junio C Hamano
2016-04-10 14:56 ` Michael S. Tsirkin
2016-04-07 17:35 ` Matthieu Moy [this message]
2016-04-07 15:23 ` [PATCH 3/4] builtin/am: read mailinfo from file Michael S. Tsirkin
2016-04-07 17:08 ` Junio C Hamano
2016-04-07 17:15 ` Michael S. Tsirkin
2016-04-07 17:36 ` Matthieu Moy
2016-04-07 15:23 ` [PATCH 4/4] builtin/am: passthrough -t and --trailer flags Michael S. Tsirkin
2016-04-07 16:39 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqoa9ltj8g.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mst@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox