From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: "patrick.reynolds\@github.com" <patrick.reynolds@github•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH] use a hashmap to make remotes faster
Date: Tue, 29 Jul 2014 09:57:45 +0200 [thread overview]
Message-ID: <vpqoaw8ha12.fsf@anie.imag.fr> (raw)
In-Reply-To: <305063.319715799-sendEmail@debian> (patrick's message of "Tue, 29 Jul 2014 03:53:42 +0000")
"patrick.reynolds@github•com" <patrick.reynolds@github•com> writes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It seems you mixed your name and email address in your config file. I
guess your name is "Patrick Reynolds", not
"patrick.reynolds@github•com".
> Remotes are stored as an array, so looking one up or adding one without
> duplication is an O(n) operation. Reading an entire config file full of
> remotes is O(n^2) in the number of remotes. For a repository with tens of
> thousands of remotes, the running time can hit multiple minutes.
Just being curious: in which senario do you have tens of thousands of
remotes?
(not an objection, it's a good thing anyway)
> +static inline void init_remotes_hash()
static inline void init_remotes_hash(void)
Not a detailed review, but the patch sounds good other than that.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-29 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 3:53 [PATCH] use a hashmap to make remotes faster patrick.reynolds
2014-07-29 7:57 ` Matthieu Moy [this message]
2014-07-29 8:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqoaw8ha12.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=patrick.reynolds@github$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox