From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: mhagger@alum•mit.edu
Cc: git@vger•kernel.org, Andy Parkins <andyparkins@gmail•com>,
Sitaram Chamarty <sitaramc@gmail•com>
Subject: Re: [RFC] Add a new email notification script to "contrib"
Date: Wed, 18 Jul 2012 09:52:32 +0200 [thread overview]
Message-ID: <vpqobndld4v.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1342249182-5937-1-git-send-email-mhagger@alum.mit.edu> (mhagger@alum.mit.edu's message of "Sat, 14 Jul 2012 08:59:42 +0200")
mhagger@alum•mit.edu writes:
> * One email per commit [1]. For each reference change, the script
> first emits one email summarizing the reference change (including
> one-line summaries of the new commits), then emits a separate email
> for each new commit that was introduced, including patches.
I have a dirty hack to do that on my private repositories (instead of
sending mail on receive, the script runs as a cron job, does a "git
fetch" on each repo on my machine, and sends me patches for new commits
with "git send-email"). I had several problems with it:
* Binary content was sometimes embedded in the patch. It's cool that
"git send-email" can base64-encode content when I send a patch to
someone, but it's counter-productive when used for code review. So, I
used "git format-patch --no-binary".
* Even with that, I sometimes had overly long lines (e.g. non-text files
that were shown as a one long line, I don't remember exactly the
use-case, probably postscript files or so) that were confusing my
mailer. So, I added
# Truncate long lines
perl -pi -e 's/^(.{500}).*/$1 [...]/' $patches
to my script to truncate them.
You probably want to test these cases, and allow (configurably) the user
to do some cleanup on patches before they are sent.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2012-07-18 7:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 6:59 [RFC] Add a new email notification script to "contrib" mhagger
2012-07-14 9:46 ` Stefan Näwe
[not found] ` <CALUzUxoi-X2nTTFF7utJz2DOTDE8-s7QOgR=HmQAkOVkGY17BA@mail.gmail.com>
2012-07-14 12:03 ` Stefan Naewe
2012-07-15 4:38 ` Michael Haggerty
2012-07-15 7:11 ` Junio C Hamano
2012-07-15 22:45 ` Michael Haggerty
2012-07-16 15:57 ` Marc Branchaud
2012-07-16 16:38 ` Michael Haggerty
2012-07-16 16:16 ` Matthieu Moy
2012-07-16 16:48 ` Michael Haggerty
2012-07-16 17:47 ` Junio C Hamano
2012-07-16 19:05 ` Michael Haggerty
2012-07-16 19:21 ` Junio C Hamano
2012-07-18 7:52 ` Matthieu Moy [this message]
2012-07-20 10:01 ` Michael Haggerty
2012-11-07 21:47 ` Ævar Arnfjörð Bjarmason
2012-11-08 9:42 ` Michael Haggerty
2012-11-08 11:39 ` Ævar Arnfjörð Bjarmason
2012-11-08 12:17 ` Michael Haggerty
2012-11-08 15:38 ` Ævar Arnfjörð Bjarmason
2012-11-22 7:32 ` Michael Haggerty
2012-11-08 16:24 ` Marc Branchaud
2012-11-08 16:37 ` Ævar Arnfjörð Bjarmason
2012-11-08 16:46 ` Marc Branchaud
2012-11-08 16:03 ` Marc Branchaud
2012-11-22 7:27 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqobndld4v.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=andyparkins@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=sitaramc@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox