From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: "git discussion list" <git@vger•kernel.org>,
"Andy Parkins" <andyparkins@gmail•com>,
"Sitaram Chamarty" <sitaramc@gmail•com>,
"Junio C Hamano" <gitster@pobox•com>,
"Marc Branchaud" <mbranchaud@xiplink•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Chris Hiestand" <chiestand@salk•edu>
Subject: Re: [RFC v2] git-multimail: a replacement for post-receive-email
Date: Wed, 13 Feb 2013 15:56:25 +0100 [thread overview]
Message-ID: <vpqtxpgb6ue.fsf@grenoble-inp.fr> (raw)
In-Reply-To: <5104E738.602@alum.mit.edu> (Michael Haggerty's message of "Sun, 27 Jan 2013 09:37:12 +0100")
Michael Haggerty <mhagger@alum•mit.edu> writes:
> A while ago, I submitted an RFC for adding a new email notification
> script to "contrib" [1]. The reaction seemed favorable and it was
> suggested that the new script should replace post-receive-email rather
> than be added separately, ideally with some kind of migration support.
I think replacing the old post-receive-email is a sane goal in the long
run, but a good first step would be to have git-multimail merged in
contrib, and start considering the old script as deprecated (keeping the
old script doesn't harm IMHO, it's a one-file, 3 commits/year script,
not really a maintainance burden).
I started playing with git-multimail. In short, I do like it but had to
fight a bit with python to get it to work, and couldn't get it to do
exactly what I expect. Pull request attached :-).
Installation troubles:
I had an old python installation (Red Hat package, and I'm not root),
that did not include the email.utils package, so I couldn't use my
system's python. I found no indication about python version in README,
so I installed the latest python by hand, just to find out that
git-multimail wasn't compatible with Python 3.x. 2to3 can fix
automatically a number of 3.x compatibility issues, but not all of them
so I gave up and installed Python 2.7.
I think adding a short "dependencies" section in the README (or in an
INSTALL file) saying which Python version works could save new users the
trouble (I see the sheebang inside the scripts says python2 but since I
couldn't use my system's python and called
"path/to/python git_multimail.py", this didn't help). Making the script
portable with python 2 and 3 would be awesome ;-).
Missing feature:
git-multimail can send a summary for each push, with the "git log --oneline"
of the new revisions, and then 1 mail per patch with the complete log
and the patch.
I'd like to have the intermediate: allow the summary email to include
the complete log (not just --oneline). My colleagues already think they
receive too many emails so I don't think they'd like the "one email per
commit" way, but the 1 line summary is really short OTOH.
I wrote a quick and hopefully not-too-dirty implementation of it,
there's a pull request here:
https://github.com/mhagger/git-multimail/pull/6
essentially, it boils down to:
@@ -835,6 +837,17 @@ class ReferenceChange(Change):
for line in self.expand_lines(NO_NEW_REVISIONS_TEMPLATE):
yield line
+ if adds and self.showlog:
+ yield '\n'
+ yield 'Detailed log of added commits:\n\n'
+ for line in read_lines(
+ ['git', 'log']
+ + self.logopts
+ + ['%s..%s' % (self.old.commit, self.new.commit,)],
+ keepends=True,
+ ):
+ yield line
+
# The diffstat is shown from the old revision to the new
# revision. This is to show the truth of what happened in
# this change. There's no point showing the stat from the
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-02-13 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 8:37 [RFC v2] git-multimail: a replacement for post-receive-email Michael Haggerty
2013-01-29 15:25 ` Ævar Arnfjörð Bjarmason
2013-01-30 2:27 ` Chris Hiestand
2013-02-13 14:56 ` Matthieu Moy [this message]
2013-02-13 15:26 ` Andy Parkins
2013-02-13 16:12 ` Matthieu Moy
2013-02-13 21:42 ` Michael Haggerty
2013-02-14 12:55 ` Matthieu Moy
2013-02-15 5:07 ` Michael Haggerty
2013-02-20 12:28 ` Matthieu Moy
2013-02-24 5:31 ` Michael Haggerty
2013-02-25 9:54 ` Matthieu Moy
2013-02-25 10:50 ` Michael Haggerty
2013-03-09 5:32 ` Michael Haggerty
2013-02-24 5:53 ` Michael Haggerty
2013-02-25 10:01 ` Matthieu Moy
2013-03-04 8:56 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqtxpgb6ue.fsf@grenoble-inp.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=andyparkins@gmail$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=chiestand@salk$(echo .)edu \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mbranchaud@xiplink$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=sitaramc@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox