public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@imag•fr>
To: Eric Wong <normalperson@yhbt•net>
Cc: Junio C Hamano <junkio@cox•net>, git@vger•kernel.org
Subject: Re: [PATCH] git-svn: avoid crashing svnserve when creating new directories
Date: Sat, 19 May 2007 12:19:05 +0200	[thread overview]
Message-ID: <vpqtzu9m7za.fsf@bauges.imag.fr> (raw)
In-Reply-To: <20070519095837.GA387@muzzle> (Eric Wong's message of "Sat\, 19 May 2007 02\:58\:37 -0700")

Eric Wong <normalperson@yhbt•net> writes:

>  	foreach (sort { $b =~ tr#/#/# <=> $a =~ tr#/#/# } keys %$bat) {
> +		next if $_ eq '';
>  		$self->close_directory($bat->{$_}, $p);
>  	}
> +	$self->close_directory($bat->{''}, $p);

Works for me. Thanks a lot!

BTW, I didn't have time to write my script as a real testcase for
git-svn, but it should probably be added to the testsuite.

Thanks again,

-- 
Matthieu

  reply	other threads:[~2007-05-19 10:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11  9:09 [BUG] git-svn dcommit fails (connection closed unexpectedly) Matthieu Moy
2007-05-11 11:27 ` Lars Hjemli
2007-05-11 11:30   ` Lars Hjemli
2007-05-11 12:51   ` Matthieu Moy
2007-05-14 18:13   ` Matthieu Moy
2007-05-19  6:14     ` Eric Wong
2007-05-19  9:58       ` [PATCH] git-svn: avoid crashing svnserve when creating new directories Eric Wong
2007-05-19 10:19         ` Matthieu Moy [this message]
2007-05-19 10:58           ` Eric Wong
2007-05-19 12:02             ` Matthieu Moy
2007-05-13 17:17 ` [BUG] git-svn dcommit fails (connection closed unexpectedly) Eric Wong
2007-05-13 17:49   ` Martin Eisenhardt
2007-05-13 18:24     ` Karl Hasselström
2007-05-13 21:01       ` Eric Wong
2007-05-14  0:39         ` Eric Wong
2007-05-14 17:26         ` Linus Torvalds
2007-05-14 17:50           ` Matthieu Moy
2007-05-14 12:27   ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqtzu9m7za.fsf@bauges.imag.fr \
    --to=matthieu.moy@imag$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=junkio@cox$(echo .)net \
    --cc=normalperson@yhbt$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox