public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Stefan Beller <sbeller@google•com>
Cc: jrnieder@gmail•com, git@vger•kernel.org
Subject: Re: [RFD PATCH 0/3] Free all the memory!
Date: Tue, 17 May 2016 11:05:06 +0200	[thread overview]
Message-ID: <vpqvb2drr5p.fsf@anie.imag.fr> (raw)
In-Reply-To: <20160517032247.25092-1-sbeller@google.com> (Stefan Beller's message of "Mon, 16 May 2016 20:22:44 -0700")

Stefan Beller <sbeller@google•com> writes:

> The end goal of this (unfinished) series is to close all intentional memory
> leaks when enabling the -DFREE_ALL_MEMORY switch. This is just
> demonstrating how the beginning of such a series could look like.

One potential issue with this is: if all developers and the testsuite
use this -DFREE_ALL_MEMORY, the non-free-all-memory setup will not be
well tested, and still this is the one used by real people. For example,
if there's a really annoying memory leak hidden by FREE_ALL_MEMORY, we
may not notice it.

Perhaps it'd be better to activate FREE_ALL_MEMORY only when tools like
valgrind or so is used.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

      parent reply	other threads:[~2016-05-17  9:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  3:22 [RFD PATCH 0/3] Free all the memory! Stefan Beller
2016-05-17  3:22 ` [PATCH 1/3] mv: free memory at the end if desired Stefan Beller
2016-05-17  4:14   ` Torsten Bögershausen
2016-05-17  3:22 ` [PATCH 2/3] pack-redundant: free all memory Stefan Beller
2016-05-17  3:42   ` Eric Sunshine
2016-05-17  3:22 ` [PATCH 3/3] rev-parse: " Stefan Beller
2016-05-17  3:41 ` [RFD PATCH 0/3] Free all the memory! Eric Sunshine
2016-05-17 12:08   ` Eric Wong
2016-05-17 17:58   ` Stefan Beller
2016-05-17 18:16     ` Junio C Hamano
2016-05-17 18:20       ` Stefan Beller
2016-05-18  7:23     ` Eric Wong
2016-05-18 15:19     ` Ævar Arnfjörð Bjarmason
2016-05-17  5:46 ` David Turner
2016-05-17  9:05 ` Matthieu Moy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqvb2drr5p.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=sbeller@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox