From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Louis-Alexandre Stuber <stuberl@ensimag•grenoble-inp.fr>
Cc: Christian Couder <christian.couder@gmail•com>,
git <git@vger•kernel.org>,
remi galan-alfonso <remi.galan-alfonso@ensimag•grenoble-inp.fr>,
remi lespinet <remi.lespinet@ensimag•grenoble-inp.fr>,
guillaume pages <guillaume.pages@ensimag•grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>,
j franck7 <j_franck7@msn•com>,
Valentin Duperray <valentinduperray@gmail•com>,
Thomas Nguy <thomasxnguy@gmail•com>,
lucienkong@hotmail•com,
Christian Couder <chriscool@tuxfamily•org>
Subject: Re: [PATCH 1/2] git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.
Date: Mon, 08 Jun 2015 13:54:57 +0200 [thread overview]
Message-ID: <vpqvbeybejy.fsf@anie.imag.fr> (raw)
In-Reply-To: <1179544255.257552.1433703835857.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Louis-Alexandre Stuber's message of "Sun, 7 Jun 2015 21:03:55 +0200 (CEST)")
Please, don't top-post on this list.
Louis-Alexandre Stuber <stuberl@ensimag•grenoble-inp.fr> writes:
> Thank you for the feedback. We are trying to apply all of your suggestions, but we would prefer to rebase the history before doing some of them (like renaming variables).
>
> About the BISECT_OLDNEWMODE file: The current implementation changes almost nothing to revision.c. We thought it was better, even if it needs a new file. The code for bisect uses BISECT_TERMS because 3 states are
> possible: 'bad/good mode', 'old/new mode', or 'no bisection started'
> (if BISECT_TERMS doesn't exist).
I don't think it's the main reason. The point is to make the code
generic: once the bisection has started and the terms are chosen, the
possible states for a commit are not really bad/good or old/new, but
'first line in BISECT_TERMS/second line in BISECT_TERMS'.
> But the other files (like revision.c) don't need all these
> informations, so we thought it would be good to check if a file exists
> instead of reusing BISECT_TERMS, which would require reading its
> content.
>
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> De: "Christian Couder" <christian.couder@gmail•com>
> ...
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2015-06-08 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 16:34 [PATCH 1/2] git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced Louis Stuber
2015-06-05 16:34 ` [PATCH 2/2] Fix git rev-list --bisect and git bisect visualize when the bisection is done in old/new mode Louis Stuber
2015-06-05 20:24 ` Eric Sunshine
2015-06-05 20:03 ` [PATCH 1/2] git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced Eric Sunshine
2015-06-08 11:48 ` Matthieu Moy
2015-06-05 20:24 ` Christian Couder
[not found] ` <1179544255.257552.1433703835857.JavaMail.zimbra@ensimag.grenoble-inp.fr>
2015-06-07 19:06 ` Louis-Alexandre Stuber
2015-06-08 11:54 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvbeybejy.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=j_franck7@msn$(echo .)com \
--cc=lucienkong@hotmail$(echo .)com \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
--cc=stuberl@ensimag$(echo .)grenoble-inp.fr \
--cc=thomasxnguy@gmail$(echo .)com \
--cc=valentinduperray@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox