From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: Ramsay Jones <ramsay@ramsay1•demon.co.uk>,
git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH v3 5/6] config: add `git_die_config()` to the config-set API
Date: Mon, 28 Jul 2014 13:16:15 +0200 [thread overview]
Message-ID: <vpqvbqhu41s.fsf@anie.imag.fr> (raw)
In-Reply-To: <53D62DBD.9@gmail.com> (Tanay Abhra's message of "Mon, 28 Jul 2014 16:32:21 +0530")
Tanay Abhra <tanayabh@gmail•com> writes:
> On 7/28/2014 4:25 PM, Ramsay Jones wrote:
>> On 28/07/14 11:33, Tanay Abhra wrote:
>>> + if (!kv_info->linenr)
>>> + die("unable to parse command-line config");
>>> + else
>>> + die("bad config file line %d in %s",kv_info->linenr, kv_info->filename);
>>
>> How about including the 'key' string in the error message?
>> Similar comment applies to an earlier patch in this series.
>>
>
> git_config_get_string & pathname() are already raising a
> config_error_nonbool() with the error message,
> "Missing value for 'key'".
>
> For other cases, I was just following the previous error message,
> but it can be done for the new git_config().
It is good to follow the existing in this patch (better code, same
behavior), but I agree with Ramsay that including key in the error
message (for both branches of the if/then/else) in a further patch would
be good, and should be straightforward enough.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-28 11:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 10:33 [PATCH v3 0/6] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 1/6] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 2/6] add line number and file name info to `config_set` Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 3/6] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-28 10:33 ` [PATCH v3 4/6] add a test for semantic errors in config files Tanay Abhra
2014-07-28 11:22 ` Matthieu Moy
2014-07-28 11:27 ` Tanay Abhra
2014-07-28 11:38 ` Matthieu Moy
2014-07-28 10:33 ` [PATCH v3 5/6] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-28 10:55 ` Ramsay Jones
2014-07-28 11:02 ` Tanay Abhra
2014-07-28 11:16 ` Matthieu Moy [this message]
2014-07-28 11:14 ` Matthieu Moy
2014-07-28 10:33 ` [PATCH v3 6/6] add tests for `git_config_get_string_const()` Tanay Abhra
2014-07-28 11:24 ` [PATCH v3 0/6] Rewrite `git_config()` using config-set API Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvbqhu41s.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox