Subject: Re: [PATCH v6 2/2] test-config: Add tests for the config_set API

From: Matthieu Moy <[email-masked]>
Date: Mon, 07 Jul 2014 19:04:55 +0200

Tanay Abhra <[email-masked]> writes:

> diff --git a/t/t1308-config-hash.sh b/t/t1308-config-hash.sh
> new file mode 100755
> index 0000000..ad99f8b
> --- /dev/null
> +++ b/t/t1308-config-hash.sh
> @@ -0,0 +1,168 @@
> +#!/bin/sh
> +
> +test_description='Test git config-hash API in different settings'

You may want to call it "config_set API" now.

> +#'check section.key value' verifies that the entry for section.key is
> +#'value'

Style: space after #.

> +check() {
> +	echo "$2" >expected
> +	test-config get_value "$1" >actual 2>&1
> +	test_cmp actual expected
> +}

You need to &&-chain these lines, to catch potential test-config
failures (if it returns 1 after sending the right output, you won't
notice).

The doc says

 - test_cmp <expected> <actual>

You swapped the order of parameters.

> +test_expect_success 'setup default config' '
> +	cat >.git/config << EOF

Missing && here (sorry, I should have noticed the first time).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/