Subject: Re: [PATCH v3 1/9] ref-filter: add option to align atoms to the left

From: Matthieu Moy <[email-masked]>
Date: Wed, 22 Jul 2015 20:44:08 +0200

Karthik Nayak <[email-masked]> writes:

> +			strtoul_ui(valp, 10, &ref->align_value);
> +			if (ref->align_value < 1)
> +				die(_("Value should be greater than zero"));

You're not checking the return value of strtoul_ui, which returns -1
before assigning align_value if the value can't be parsed. As a result,
you're testing an undefined value in the 'if' statement in this case.

You should test the return value and issue a distinct error message in
this case like

if (strtoul_ui(valp, 10, &ref->align_value))
	die(_("positive integer expected after ':' in align:%u\n",
	    ref_align_value));

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/