Subject: Re: [PATCH v7 05/12] for-each-ref: introduce new structures for better organisation

From: Matthieu Moy <[email-masked]>
Date: Thu, 11 Jun 2015 19:41:41 +0200

Karthik Nayak <[email-masked]> writes:

> +struct ref_filter_cbdata {
> +	struct ref_array array;
> +	struct ref_filter filter;
> +};

I didn't notice this at first, but why introduce the structure like this
when you are going to turn it into pointers later in PATCH 7:

Karthik Nayak <[email-masked]> writes:

> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -42,12 +45,17 @@ struct ref_filter {
>  };
>  
>  struct ref_filter_cbdata {
> -	struct ref_array array;
> -	struct ref_filter filter;
> +	struct ref_array *array;
> +	struct ref_filter *filter;
>  };

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/