Subject: Re: [PATCH v12 01/13] ref-filter: move `struct atom_value` to ref-filter.c

From: Matthieu Moy <[email-masked]>
Date: Wed, 19 Aug 2015 16:56:26 +0200

Karthik Nayak <[email-masked]> writes:

> +static void end_atom_handler(struct atom_value *atomv, struct ref_formatting_state **state)
> +{
> +	struct ref_formatting_state *current = *state;
> +	if (!current->at_end)
> +		die(_("format: `end` atom used without a supporting atom"));

You error out on %(end) without %(align), but not on %(align) without
%(end).

You should probably check that the stack is empty at the end and error
out otherwise.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/