From: Michal Nazarewicz <mina86@mina86•com>
To: Junio C Hamano <gitster@pobox•com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [PATCHv2 4/5] Git.pm: add interface for git credential command
Date: Fri, 08 Feb 2013 02:37:53 +0100 [thread overview]
Message-ID: <xa1t6223poum.fsf@mina86.com> (raw)
In-Reply-To: <7v7gmj66fq.fsf@alter.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Fri, Feb 08 2013, Junio C Hamano wrote:
> I'd actually be more worried about the error checking issue
> Peff raised during his review. I have a feeling that "when in doubt,
> do not cause harm" is a more prudent way to go than "I do not know,
> so I'll let anything pass".
I can implement whatever checking you wish, just tell me what to do in
corner cases I've listed. ;)
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google•com>--------------ooO--(_)--Ooo--
[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2013-02-08 1:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 14:01 [PATCHv2 0/5] Make git-send-email use git-credential Michal Nazarewicz
2013-02-07 14:01 ` [PATCHv2 1/5] Git.pm: allow command_close_bidi_pipe to be called as method Michal Nazarewicz
2013-02-07 14:01 ` [PATCHv2 2/5] Git.pm: fix example in command_close_bidi_pipe documentation Michal Nazarewicz
2013-02-07 14:01 ` [PATCHv2 3/5] Git.pm: allow pipes to be closed prior to calling command_close_bidi_pipe Michal Nazarewicz
2013-02-07 14:01 ` [PATCHv2 4/5] Git.pm: add interface for git credential command Michal Nazarewicz
2013-02-07 18:46 ` Matthieu Moy
2013-02-07 23:38 ` Junio C Hamano
2013-02-08 1:37 ` Michal Nazarewicz [this message]
2013-02-08 5:11 ` Jeff King
2013-02-07 14:01 ` [PATCHv2 5/5] git-send-email: use git credential to obtain password Michal Nazarewicz
2013-02-07 18:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1t6223poum.fsf@mina86.com \
--to=mina86@mina86$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox