From: Junio C Hamano <gitster@pobox•com>
To: "Julia Evans via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org,
"brian m. carlson" <sandals@crustytoothpaste•net>,
Jeff King <peff@peff•net>, Julia Evans <julia@jvns•ca>
Subject: Re: [PATCH v2 0/2] doc: git-push: clarify section
Date: Thu, 25 Sep 2025 08:59:52 -0700 [thread overview]
Message-ID: <xmqq1pnuikuf.fsf@gitster.g> (raw)
In-Reply-To: <pull.1973.v2.git.1758651049.gitgitgadget@gmail.com> (Julia Evans via GitGitGadget's message of "Tue, 23 Sep 2025 18:10:47 +0000")
"Julia Evans via GitGitGadget" <gitgitgadget@gmail•com> writes:
> I don't love the nested list in PUSH RULES but the sentence starting with
> "If the source is a tag or commit object..." is really a tough one to read,
> it's not going to be relevant to the vast majority of people, and I think
> keeping it contained inside a bullet point will make it much easier to skip
> over to get to later information which is more likely to be relevant to
> folks.
> ...
> Changes in v2:
>
> * Say just "The source can be any object." and don't try to educate folks
> further about tags, from Junio's review
> * Mention both exceptions to --force working, from Junio's review
> * Change "local branch or commit being pushed" => "commit being pushed" to
> make it clear that it's just 1 condition, from Junio's review
> * Remove an awkward double colon, from Junio's review
> * Be explicit that creations are always allowed, from Junio's revew
Nothing questionable stood out during my re-read of these two
patches.
Further comments from other reviewers are always welcome, but we
find needs for immediate improvements, let's mark the topic for
'next'. Thanks.
prev parent reply other threads:[~2025-09-25 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 21:33 [PATCH 0/2] doc: git-push: clarify section Julia Evans via GitGitGadget
2025-09-17 21:33 ` [PATCH 1/2] doc: git-push: create PUSH RULES section Julia Evans via GitGitGadget
2025-09-17 22:35 ` Junio C Hamano
2025-09-18 20:48 ` Julia Evans
2025-09-17 21:33 ` [PATCH 2/2] doc: git-push: rewrite refspec specification Julia Evans via GitGitGadget
2025-09-19 0:39 ` [PATCH 0/2] doc: git-push: clarify section brian m. carlson
2025-09-19 4:25 ` Jeff King
2025-09-23 18:08 ` Julia Evans
2025-09-23 18:10 ` [PATCH v2 " Julia Evans via GitGitGadget
2025-09-23 18:10 ` [PATCH v2 1/2] doc: git-push: create PUSH RULES section Julia Evans via GitGitGadget
2025-09-23 18:10 ` [PATCH v2 2/2] doc: git-push: rewrite refspec specification Julia Evans via GitGitGadget
2025-09-23 21:54 ` [PATCH v2 0/2] doc: git-push: clarify section Junio C Hamano
2025-09-23 22:10 ` Julia Evans
2025-09-23 23:09 ` Junio C Hamano
2025-09-25 15:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pnuikuf.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=julia@jvns$(echo .)ca \
--cc=peff@peff$(echo .)net \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox