Subject: Re: [PATCH v3] pack-bitmap: remove checks before bitmap_free

From: Junio C Hamano <[email-masked]>
Date: Mon, 02 Jun 2025 23:12:35 -0700

"Lidong Yan via GitGitGadget" <[email-masked]> writes:

> +test_expect_success 'use pseudo-merge in boundary traversal' '
> +	git init pseudo-merge-boundary-traversal &&
> +	(
> +		cd pseudo-merge-boundary-traversal &&
> +
> +		git config bitmapPseudoMerge.test.pattern refs/ &&
> +		git config bitmapPseudoMerge.test.threshold now &&
> +		git config bitmapPseudoMerge.test.stableThreshold now &&

> +		GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1 &&

Either before or after that line, don't you need to 

		export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL &&

as well?

And if the test passed without exporting the variable, is it really
testing what we want to test?

> +		test_commit A &&
> +		git repack -adb &&
> +		test_commit B &&
> +
> +		echo '1' >expect &&
> +		git rev-list --count --use-bitmap-index HEAD~1..HEAD >actual &&
> +		test_cmp expect actual
> +	)
> +'
> +
>  test_done
>
> base-commit: 845c48a16a7f7b2c44d8cb137b16a4a1f0140229