Subject: Re: [PATCH v5] builtin/reflog.c: use parse-options api for expire, delete subcommands

From: Junio C Hamano <[email-masked]>
Date: Thu, 06 Jan 2022 13:09:00 -0800

"John Cai via GitGitGadget" <[email-masked]> writes:

> From: John Cai <[email-masked]>
>
> Switching out manual arg parsing for the parse-options API for the
> expire and delete subcommands.
>
> Move explicit_expiry flag into cmd_reflog_expire_cb struct so callbacks
> can set both the value of the timestamp as well as the explicit_expiry
> flag.
>
> Signed-off-by: "John Cai" <[email-masked]>
> ---

Thanks.  Will queue.

>      @@ builtin/reflog.c: static void set_reflog_expiry_param(struct cmd_reflog_expire_c
>       +	const struct option options[] = {
>       +		OPT_BIT(0, "dry-run", &flags, N_("do not actually prune any entries"),
>       +			EXPIRE_REFLOGS_DRY_RUN),
>      -+		OPT_BIT(0, "rewrite", &flags,
>      ++			OPT_BIT(0, "rewrite", &flags,
>       +			N_("rewrite the old SHA1 with the new SHA1 of the entry that now precedes it"),

I think this change is a fat-finger; will correct while queuing.