Subject: Re: [PATCH 1/2] terminal: teach git how to save/restore its terminal settings

From: Junio C Hamano <[email-masked]>
Date: Mon, 04 Oct 2021 09:36:00 -0700

Carlo Marcelo Arenas Belón  <[email-masked]> writes:

> diff --git a/compat/terminal.c b/compat/terminal.c
> index 43b73ddc75..1fadbfd6b6 100644
> --- a/compat/terminal.c
> +++ b/compat/terminal.c
> @@ -8,7 +8,7 @@
>  
>  #if defined(HAVE_DEV_TTY) || defined(GIT_WINDOWS_NATIVE)
>  
> -static void restore_term(void);
> +void restore_term(void);

Curious why you need this because (1) we do not have the same for
save_term() here, and (2) we include compat/terminal.h where these
two are declared next to each other.