public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Mike Hommey <mh@glandium•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Allow to control the namespace for replace refs
Date: Thu, 11 Jun 2015 08:16:02 -0700	[thread overview]
Message-ID: <xmqq1thigtsd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150611051339.GA3637@glandium.org> (Mike Hommey's message of "Thu, 11 Jun 2015 14:13:40 +0900")

Mike Hommey <mh@glandium•org> writes:

> I do agree that this is all confusing, but allow me to point out that
> it's already plenty confusing: "namespace" is a term that has been used to
> designate a generic kind of namespace *and* refs/namespaces. See for
> example:
>
> https://github.com/git/git/blob/master/Documentation/git-describe.txt#L39
> https://github.com/git/git/blob/master/Documentation/git-fetch.txt#L113
> https://github.com/git/git/blob/master/Documentation/git-filter-branch.txt#L36
> (note how this one is specifically about refs/replace/)
> there are many more.

"One more breakage does not hurt" is not something we want to see.

> _REF kind of implies _one_ specific ref....

I thought about suggesting GIT_REPLACE_REFS for that exact reason,
but decided against it, because (1) if you are using replace, then
you know you are not using a single ref but a group of refs in a
single hierarchy already, and (2) if you do not know what replace
and notes are, GIT_REPLACE_REFS and GIT_NOTES_REF look just being
inconsistent (even though the intention of the difference is to be
more logical).  s/S/_BASE/ would make that better, though.

> As for exposing a pref, I'm not entirely sure it makes sense to.

I don't see an immediate need for it, and it is easy to add later,
so let's limit the scope of the initial adoption of the feature.

Thanks.

  reply	other threads:[~2015-06-11 15:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11  1:47 [PATCH] Allow to control the namespace for replace refs Mike Hommey
2015-06-11  4:55 ` Junio C Hamano
2015-06-11  5:13   ` Mike Hommey
2015-06-11 15:16     ` Junio C Hamano [this message]
2015-06-11 20:46       ` Mike Hommey
2015-06-11 20:55         ` Junio C Hamano
2015-06-11 21:34       ` [PATCH v2] Allow to control where the replace refs are looked for Mike Hommey
2015-06-12 22:29         ` Junio C Hamano
2015-06-12 22:36           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1thigtsd.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mh@glandium$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox