Subject: Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

From: Junio C Hamano <[email-masked]>
Date: Tue, 26 May 2015 15:21:37 -0700

Stefan Beller <[email-masked]> writes:

> +	if (transport->smart_options
> +	    && transport->smart_options->transport_version) {
> +		buf = xmalloc(strlen(remote_program) + 12);
> +		sprintf(buf, "%s-%d", remote_program,
> +			transport->smart_options->transport_version);
> +		remote_program = buf;
> +	}

Bikeshedding: so the versioning scheme is that the current one is
zero, and the next one is two?  I would have expected that there
would be something like

	if (...->version < 2) {
        	... append "-%d" ...
	}

involved.