From: Junio C Hamano <gitster@pobox•com>
To: David Aguilar <davvid@gmail•com>
Cc: "Sebastian Schuberth" <sschuberth@gmail•com>,
"Phil Susi" <phillsusi@gmail•com>,
"Git Mailing List" <git@vger•kernel.org>,
"Philip Oakley" <philipoakley@iee•org>,
"Johannes Schindelin" <johannes.schindelin@gmx•de>,
"SZEDER Gábor" <szeder@ira•uka.de>
Subject: Re: [PATCH v4] mergetools: add winmerge as a builtin tool
Date: Wed, 20 May 2015 13:03:36 -0700 [thread overview]
Message-ID: <xmqq1tibnhif.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150520085346.GA99001@gmail.com> (David Aguilar's message of "Wed, 20 May 2015 01:53:48 -0700")
David Aguilar <davvid@gmail•com> writes:
> On Wed, May 20, 2015 at 09:47:56AM +0200, Sebastian Schuberth wrote:
>> On Wed, May 20, 2015 at 9:42 AM, David Aguilar <davvid@gmail•com> wrote:
>>
>> > + OIFS=$IFS
>> > + IFS='
>> > +'
>>
>> I guess this is just a formatting issue with the mail export as it should read
>>
>> IFS=$'\n'
>>
>> Otherwise looks good to me.
>>
>> --
>> Sebastian Schuberth
>
> Thanks for the review.
>
> That's actually a literal newline inside a single-quoted string.
>
> I'm not sure how portable $'\n' is, but the '<literal-newline>'
> approach is used often in the git code.
Thanks for being observant ;-) Unless it is contrib/completion that
is known to be run with bash, please avoid $'string' and $"string".
prev parent reply other threads:[~2015-05-20 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 7:42 [PATCH v4] mergetools: add winmerge as a builtin tool David Aguilar
2015-05-20 7:47 ` Sebastian Schuberth
2015-05-20 8:53 ` David Aguilar
2015-05-20 20:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tibnhif.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=philipoakley@iee$(echo .)org \
--cc=phillsusi@gmail$(echo .)com \
--cc=sschuberth@gmail$(echo .)com \
--cc=szeder@ira$(echo .)uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox