From: Junio C Hamano <gitster@pobox•com>
To: "Erik Elfström" <erik.elfstrom@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v4 1/5] setup: add gentle version of read_gitfile
Date: Sat, 25 Apr 2015 09:51:45 -0700 [thread overview]
Message-ID: <xmqq1tj8178e.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1429952801-2646-2-git-send-email-erik.elfstrom@gmail.com> ("Erik Elfström"'s message of "Sat, 25 Apr 2015 11:06:37 +0200")
Erik Elfström <erik.elfstrom@gmail•com> writes:
> read_gitfile will die on most error cases. This makes it unsuitable
> for speculative calls. Extract the core logic and provide a gentle
> version that returns NULL on failure.
>
> The first usecase of the new gentle version will be to probe for
> submodules during git clean.
>
> Helped-by: Junio C Hamano <gitster@pobox•com>
> Helped-by: Jeff King <peff@peff•net>
> Signed-off-by: Erik Elfström <erik.elfstrom@gmail•com>
> ---
> cache.h | 3 ++-
> setup.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++--------------
> 2 files changed, 67 insertions(+), 18 deletions(-)
>
> diff --git a/cache.h b/cache.h
> index 3d3244b..6e29068 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -431,7 +431,8 @@ extern int set_git_dir(const char *path);
> extern const char *get_git_namespace(void);
> extern const char *strip_namespace(const char *namespaced_ref);
> extern const char *get_git_work_tree(void);
> -extern const char *read_gitfile(const char *path);
> +extern const char *read_gitfile_gently(const char *path, int *return_error_code);
> +#define read_gitfile(path) read_gitfile_gently((path), NULL)
> extern const char *resolve_gitdir(const char *suspect);
> extern void set_git_work_tree(const char *tree);
>
> diff --git a/setup.c b/setup.c
> index 979b13f..e1897cc 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -335,35 +335,53 @@ static int check_repository_format_gently(const char *gitdir, int *nongit_ok)
> /*
> * Try to read the location of the git directory from the .git file,
> * return path to git directory if found.
> + *
> + * On failure, if return_error_code is not NULL, return_error_code
> + * will be set to an error code and NULL will be returned. If
> + * return_error_code is NULL the function will die instead (for most
> + * cases).
> */
> -const char *read_gitfile(const char *path)
> +const char *read_gitfile_gently(const char *path, int *return_error_code)
> {
> - char *buf;
> - char *dir;
> + int error_code = 0;
> + char *buf = NULL;
> + char *dir = NULL;
> const char *slash;
> struct stat st;
> int fd;
> ssize_t len;
>
> - if (stat(path, &st))
> - return NULL;
> - if (!S_ISREG(st.st_mode))
> - return NULL;
> + if (stat(path, &st)) {
> + error_code = 1;
> + goto cleanup_return;
> + }
> + if (!S_ISREG(st.st_mode)) {
> + error_code = 2;
> + goto cleanup_return;
> + }
> fd = open(path, O_RDONLY);
> - if (fd < 0)
> - die_errno("Error opening '%s'", path);
> + if (fd < 0) {
> + error_code = 3;
> + goto cleanup_return;
> + }
> buf = xmalloc(st.st_size + 1);
> len = read_in_full(fd, buf, st.st_size);
> close(fd);
> - if (len != st.st_size)
> - die("Error reading %s", path);
> + if (len != st.st_size) {
> + error_code = 4;
> + goto cleanup_return;
> + }
> buf[len] = '\0';
> - if (!starts_with(buf, "gitdir: "))
> - die("Invalid gitfile format: %s", path);
> + if (!starts_with(buf, "gitdir: ")) {
> + error_code = 5;
> + goto cleanup_return;
> + }
> while (buf[len - 1] == '\n' || buf[len - 1] == '\r')
> len--;
> - if (len < 9)
> - die("No path in gitfile: %s", path);
> + if (len < 9) {
> + error_code = 6;
> + goto cleanup_return;
> + }
> buf[len] = '\0';
> dir = buf + 8;
>
> @@ -378,11 +396,41 @@ const char *read_gitfile(const char *path)
> buf = dir;
> }
>
> - if (!is_git_directory(dir))
> - die("Not a git repository: %s", dir);
> + if (!is_git_directory(dir)) {
> + error_code = 7;
> + goto cleanup_return;
> + }
> path = real_path(dir);
>
> +cleanup_return:
> free(buf);
> +
> + if (return_error_code)
> + *return_error_code = error_code;
> +
> + if (error_code) {
> + if (return_error_code)
> + return NULL;
> +
> + switch (error_code) {
> + case 1: // failed to stat
> + case 2: // not regular file
Please do not use C++ // comments.
> + return NULL;
> + case 3:
> + die_errno("Error opening '%s'", path);
> + case 4:
> + die("Error reading %s", path);
> + case 5:
> + die("Invalid gitfile format: %s", path);
> + case 6:
> + die("No path in gitfile: %s", path);
> + case 7:
> + die("Not a git repository: %s", dir);
> + default:
> + assert(0);
> + }
> + }
> +
> return path;
> }
next prev parent reply other threads:[~2015-04-25 16:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 9:06 [PATCH v4 0/5] Improving performance of git clean Erik Elfström
2015-04-25 9:06 ` [PATCH v4 1/5] setup: add gentle version of read_gitfile Erik Elfström
2015-04-25 16:51 ` Junio C Hamano [this message]
2015-04-25 16:54 ` Junio C Hamano
2015-04-25 9:06 ` [PATCH v4 2/5] setup: sanity check file size in read_gitfile_gently Erik Elfström
2015-04-25 16:47 ` Junio C Hamano
2015-04-25 17:59 ` Erik Elfström
2015-04-26 4:29 ` Junio C Hamano
2015-04-26 6:49 ` [PATCH v5 0/5] Improving performance of git clean Erik Elfström
2015-04-26 6:49 ` [PATCH v5 1/5] setup: add gentle version of read_gitfile Erik Elfström
2015-04-28 6:17 ` Jeff King
2015-04-28 20:07 ` erik elfström
2015-04-28 20:19 ` Jeff King
2015-04-28 20:34 ` Jonathan Nieder
2015-04-28 20:36 ` Jeff King
2015-04-28 20:42 ` Jonathan Nieder
2015-04-28 20:48 ` Jeff King
2015-04-28 21:06 ` Jonathan Nieder
2015-04-28 23:34 ` Junio C Hamano
2015-04-29 23:47 ` Stefan Beller
2015-04-30 1:35 ` Junio C Hamano
2015-04-26 6:49 ` [PATCH v5 2/5] setup: sanity check file size in read_gitfile_gently Erik Elfström
2015-04-28 6:02 ` Jeff King
2015-04-28 7:21 ` Windows path limites, was " Johannes Schindelin
2015-04-28 15:33 ` Doug Kelly
2015-04-28 16:20 ` Windows path limits, " Johannes Schindelin
2015-04-28 19:28 ` erik elfström
2015-04-29 15:42 ` Junio C Hamano
2015-04-26 6:49 ` [PATCH v5 3/5] t7300: add tests to document behavior of clean and nested git Erik Elfström
2015-04-26 6:49 ` [PATCH v5 4/5] p7300: add performance tests for clean Erik Elfström
2015-04-28 6:33 ` Jeff King
2015-04-28 19:36 ` erik elfström
2015-04-26 6:49 ` [PATCH v5 5/5] clean: improve performance when removing lots of directories Erik Elfström
2015-04-28 6:24 ` Jeff King
2015-04-28 20:31 ` erik elfström
2015-04-25 9:06 ` [PATCH v4 3/5] t7300: add tests to document behavior of clean and nested git Erik Elfström
2015-04-25 9:06 ` [PATCH v4 4/5] p7300: add performance tests for clean Erik Elfström
2015-04-25 9:06 ` [PATCH v4 5/5] clean: improve performance when removing lots of directories Erik Elfström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tj8178e.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=erik.elfstrom@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox