From: Junio C Hamano <gitster@pobox•com>
To: Git Mailing List <git@vger•kernel.org>
Cc: kelson@shysecurity•com, Philip Oakley <philipoakley@iee•org>,
Duy Nguyen <pclouds@gmail•com>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH 2/2] support for --no-relative and diff.relative
Date: Thu, 12 Feb 2015 15:17:56 -0800 [thread overview]
Message-ID: <xmqq1tlupvmj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: 54A2FDD2.3010707@shysecurity.com
These two patches
* bp/diff-relative-config (2015-01-07) 2 commits
- diff: teach diff.relative to give default to --relative=<value>
- diff: teach --no-relative to override earlier --relative
have been sitting in my Undecided pile, primarily because I am wary
of touching a core command like "diff" with just me reviewing. I
think they look reasonably safe (especially since the configuration
parsing is done only in diff_ui_config()), but I may have overlooked
something obvious and silly.
Another set or two of eyeballs are very much appreciated.
Thanks.
prev parent reply other threads:[~2015-02-12 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 20:23 [PATCH v3 2/2] git-config support for diff.relative setting kelson
2014-12-30 17:56 ` kelson
2014-12-30 19:32 ` [PATCH 2/2] support for --no-relative and diff.relative kelson
2015-01-06 16:19 ` kelson
2015-02-12 23:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tlupvmj.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=kelson@shysecurity$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=philipoakley@iee$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox