From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "René Scharfe" <l.s.r@web•de>,
"Git Mailing List" <git@vger•kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Subject: Re: [PATCH] receive-pack: plug minor memory leak in unpack()
Date: Mon, 13 Oct 2014 12:08:09 -0700 [thread overview]
Message-ID: <xmqq1tqb4wkm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141012015321.GA15272@peff.net> (Jeff King's message of "Sat, 11 Oct 2014 21:53:21 -0400")
Jeff King <peff@peff•net> writes:
> On Sat, Oct 11, 2014 at 01:00:16PM +0200, René Scharfe wrote:
>
>> The argv_array used in unpack() is never freed. Instead of adding
>> explicit calls to argv_array_clear() use the args member of struct
>> child_process and let run_command() and friends clean up for us.
>
> Looks good. I notice that the recently added prepare_push_cert_sha1 uses
> an argv_array to create the child_process.env, and we leak the result.
You're right. finish_command() runs argv_array_clear() on
cmd->args, but does not care about cmd->env so anybody that use the
(optional) "use these environment variable settings while running
the command" would leak unless the caller takes care of it.
> I wonder if run-command should provide a managed env array similar
> to the "args" array.
I took a look at a few of them:
- setup_pager() uses a static set of environment variables that are
not built with argv_array(); should be easy to convert, though.
- wt_status_print_submodule_summary() does use two argv_arrays, for
env and argv. It can use the managed "args" today, and with such
a change it can also use the managed "envs".
- receive-pack.c::prepare_push_cert_sha1() would benefit from
managed "envs".
- http-backend.c::run_service() would benefit from managed "envs".
- daemon.c::handle() uses a static set of environment variables
that are not built with argv_array(). Same for argv.
It shouldn't be too hard to catch and convert all of them.
next prev parent reply other threads:[~2014-10-13 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 11:00 [PATCH] receive-pack: plug minor memory leak in unpack() René Scharfe
2014-10-12 1:53 ` Jeff King
2014-10-13 19:08 ` Junio C Hamano [this message]
2014-10-14 9:16 ` Jeff King
2014-10-19 11:13 ` René Scharfe
2014-10-20 9:19 ` Jeff King
2014-10-19 11:13 ` [PATCH 1/2] run-command: add env_array, an optional argv_array for env René Scharfe
2014-10-19 11:14 ` [PATCH 2/2] use env_array member of struct child_process René Scharfe
2014-10-20 9:19 ` Jeff King
2014-11-09 13:49 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tqb4wkm.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox