From: Junio C Hamano <gitster@pobox•com>
To: Avi Kivity <avi@cloudius-systems•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2] git-am: add option to extract email Message-Id: tag into commit log
Date: Wed, 02 Jul 2014 10:17:13 -0700 [thread overview]
Message-ID: <xmqq1tu3isti.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1404291113-4424-1-git-send-email-avi@cloudius-systems.com> (Avi Kivity's message of "Wed, 2 Jul 2014 11:51:53 +0300")
Avi Kivity <avi@cloudius-systems•com> writes:
> + if test 't' == "$message_id"
> + then
> + grep ^Message-Id: "$dotest/info" || true
> + fi
> if test '' != "$ADD_SIGNOFF"
> then
> echo "$ADD_SIGNOFF"
Seeing how existing code carefully makes sure that ADD_SIGNOFF has
an empty line before it when and only when necessary to ensure that
there is a blank after the existing log message, I would suspect
that this patch that blindly inserts a line is doubly wrong. The
output from "grep" may be appended without adding a blank when
necessary, and appending of ADD_SIGNOFF may end up adding an extra
blank after Message-Id. Am I reading the patch wrong?
next prev parent reply other threads:[~2014-07-02 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 8:51 [PATCH v2] git-am: add option to extract email Message-Id: tag into commit log Avi Kivity
2014-07-02 9:58 ` Torsten Bögershausen
2014-07-02 13:54 ` Avi Kivity
2014-07-02 14:18 ` Fabian Ruch
2014-07-02 14:44 ` Avi Kivity
2014-07-02 17:17 ` Junio C Hamano [this message]
2014-07-03 14:08 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tu3isti.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=avi@cloudius-systems$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox