From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Ramsay Jones <ramsay@ramsay1•demon.co.uk>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] alloc.c: remove alloc_raw_commit_node() function
Date: Thu, 19 Jun 2014 13:32:04 -0700 [thread overview]
Message-ID: <xmqq1tuc8ypr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140619091924.GA29478@sigill.intra.peff.net> (Jeff King's message of "Thu, 19 Jun 2014 05:19:24 -0400")
Jeff King <peff@peff•net> writes:
> For a while some people were compiling git with pretty antique
> compilers, but I do not know if that is the case any more (Junio noted
> recently that we have had trailing commas on arrays and enums in
> builtin/clean.c for the past year, and nobody has complained).
IIRC, the problematic is a trailing comma in enum definitions, not
array initialisations.
prev parent reply other threads:[~2014-06-25 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 19:52 [PATCH] alloc.c: remove alloc_raw_commit_node() function Ramsay Jones
2014-06-18 20:08 ` Jeff King
2014-06-18 22:30 ` Ramsay Jones
2014-06-19 9:19 ` Jeff King
2014-06-19 9:55 ` Ramsay Jones
2014-06-19 20:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tuc8ypr.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox