Subject: Re: [PATCHv3 5/5] t7510: test verify-commit

From: Junio C Hamano <[email-masked]>
Date: Mon, 23 Jun 2014 16:02:30 -0700

Michael J Gruber <[email-masked]> writes:

>  test_expect_success GPG 'detect fudged signature' '
>  	git cat-file commit master >raw &&
>  
>  	sed -e "s/seventh/7th forged/" raw >forged1 &&
>  	git hash-object -w -t commit forged1 >forged1.commit &&
> +	! git verify-commit $(cat forged1.commit) &&

This should be "test_must_fail git verify-commit ...", I think.
Otherwise you would end up declaring a segfaulting implementation a
good one.

> +	! git verify-commit $(cat forged2.commit) &&

Likewise.