From: Junio C Hamano <gitster@pobox•com>
To: Ronnie Sahlberg <sahlberg@google•com>
Cc: git@vger•kernel.org, mhagger@alum•mit.edu
Subject: Re: [PATCH] add a reflog_exists and delete_reflog abstraction
Date: Tue, 06 May 2014 12:15:10 -0700 [thread overview]
Message-ID: <xmqq1tw6g1mp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1399330677-17930-1-git-send-email-sahlberg@google.com> (Ronnie Sahlberg's message of "Mon, 5 May 2014 15:57:56 -0700")
Ronnie Sahlberg <sahlberg@google•com> writes:
> It currently has a hard assumption that the loose ref file must exist at this
> stage or else it would end up deleting the reflog which is true today, as far
> as I can tell, but would break if git would change such that we could have
> a branch checked out without having a loose ref file for that branch.
Hmmmm. Do you mean this sequence will break?
: gitster x; git init lo
Initialized empty Git repository in /var/tmp/x/lo/.git/
: gitster x; cd lo
: gitster lo/master; git commit --allow-empty -m initial
[master (root-commit) db2b430] initial
: gitster lo/master; git branch next
Now we have two branches, master and next, and we are on master.
: gitster lo/master; git pack-refs --all
: gitster lo/master; ls .git/refs/heads
./ ../
: gitster lo/master; cat .git/packed-refs
# pack-refs with: peeled fully-peeled
db2b43072749258d1e3c119c9570349d77c26b3a refs/heads/master
db2b43072749258d1e3c119c9570349d77c26b3a refs/heads/next
And loose refs are fully packed.
: gitster lo/master; git checkout next
Switched to branch 'next'
: gitster lo/next; ls .git/refs/heads
./ ../
next prev parent reply other threads:[~2014-05-06 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 22:57 [PATCH] add a reflog_exists and delete_reflog abstraction Ronnie Sahlberg
2014-05-05 22:57 ` [PATCH] refs.c: add new functions reflog_exists and delete_reflog Ronnie Sahlberg
2014-05-06 15:55 ` Michael Haggerty
2014-05-06 18:21 ` Ronnie Sahlberg
2014-05-06 15:23 ` [PATCH] add a reflog_exists and delete_reflog abstraction Michael Haggerty
2014-05-07 20:47 ` Ronnie Sahlberg
2014-05-06 19:15 ` Junio C Hamano [this message]
2014-05-06 19:29 ` Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tw6g1mp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=sahlberg@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox