public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Linus Arver via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org,  Christian Couder <chriscool@tuxfamily•org>,
	Linus Arver <linus@ucla•edu>
Subject: Re: [PATCH] trailer: spread usage of "trailer_block" language
Date: Tue, 12 Nov 2024 11:16:10 +0900	[thread overview]
Message-ID: <xmqq34jx8adx.fsf@gitster.g> (raw)
In-Reply-To: <pull.1811.git.git.1728820722580.gitgitgadget@gmail.com> (Linus Arver via GitGitGadget's message of "Sun, 13 Oct 2024 11:58:42 +0000")

"Linus Arver via GitGitGadget" <gitgitgadget@gmail•com> writes:

> From: Linus Arver <linusa@google•com>
>
> Deprecate the "trailer_info" struct name and replace it with
> "trailer_block". This is more readable, for two reasons:
>
>   1. "trailer_info" on the surface sounds like it's about a single
>      trailer when in reality it is a collection of one or more trailers,
>      and
>
>   2. the "*_block" suffix is more informative than "*_info", because it
>      describes a block (or region) of contiguous text which has trailers
>      in it, which has been parsed into the trailer_block structure.
>
> Rename the
>
>     size_t trailer_block_start, trailer_block_end;
>
> members of trailer_info to just "start" and "end". Rename the "info"
> pointer to "trailer_block" because it is more descriptive. Update
> comments accordingly.

All makes sense.  Often "_info" suffix has very low information
density, as everything is "info" in a sense ;-)

This was a more-or-less mechanical and straight-forward renaming of
a handful of variables and structure fields.  It is a shame that
nobody bothered to review these changes (or say "this does not make
anything worse, but is it worth it?" to object to it, for that
matter) for almost a month.

Will merge to 'next' (unless there is a belated "it may not break,
but it is not a good idea because ...", that is).

Thanks.

next prev parent reply	other threads:[~2024-11-12  2:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-13 11:58 [PATCH] trailer: spread usage of "trailer_block" language Linus Arver via GitGitGadget
2024-10-15 11:32 ` Linus Arver
2024-10-15 19:47   ` Taylor Blau
2024-11-05 21:02   ` Johannes Schindelin
2024-11-12 10:39     ` Linus Arver
2024-11-12  2:16 ` Junio C Hamano [this message]
2024-11-12 10:49   ` Linus Arver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq34jx8adx.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=chriscool@tuxfamily$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitgitgadget@gmail$(echo .)com \
    --cc=linus@ucla$(echo .)edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox