Subject: Re: [PATCH v2 2/2] blame: document --color-* options

From: Junio C Hamano <[email-masked]>
Date: Wed, 29 Sep 2021 12:15:29 -0700

Bagas Sanjaya <[email-masked]> writes:

> Commit cdc2d5f11f1a (builtin/blame: dim uninteresting metadata lines,
> 2018-04-23) and 25d5f52901f0 (builtin/blame: highlight recently changed
> lines, 2018-04-23) introduce --color-lines and --color-by-age options to
> git blame, respectively. While both options are mentioned in usage help,
> they aren't documented in git-blame(1). Document them.
>
> Co-authored-by: Dr. Matthias St. Pierre <[email-masked]>
> Signed-off-by: Dr. Matthias St. Pierre <[email-masked]>
> Signed-off-by: Bagas Sanjaya <[email-masked]>
> ---
>  Documentation/blame-options.txt | 12 ++++++++++++
>  Documentation/config/color.txt  | 12 ++++++------
>  Documentation/git-blame.txt     |  4 ++--
>  3 files changed, 20 insertions(+), 8 deletions(-)

Nicely written.

> +--color-lines::
> +	Color lines differently, if they belong to the same commit as the preceding line.

Is "belong" the right verb?  I view these lines "come from" their
originating commits, so "they belong to" -> "they come from",
perhaps.

>  color.blame.repeatedLines::
> -	Use the customized color for the part of git-blame output that
> -	is repeated meta information per line (such as commit id,
> -	author name, date and timezone). Defaults to cyan.
> +	Use the specified color to colorize line annotations, if they belong to the

Ditto.

Thanks.