public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "René Scharfe" <l.s.r@web•de>
Cc: Git List <git@vger•kernel.org>, Eric Wong <e@80x24•org>
Subject: Re: [PATCH] use fspathhash() everywhere
Date: Fri, 30 Jul 2021 12:27:09 -0700	[thread overview]
Message-ID: <xmqq35rv1u2a.fsf@gitster.g> (raw)
In-Reply-To: <b85ed04f-ef9c-f460-e21b-bd1f8dfba9e2@web.de> ("René Scharfe"'s message of "Fri, 30 Jul 2021 21:06:58 +0200")

René Scharfe <l.s.r@web•de> writes:

> cf2dc1c238 (speed up alt_odb_usable() with many alternates, 2021-07-07)
> introduced the function fspathhash() for calculating path hashes while
> respecting the configuration option core.ignorecase.  Call it instead of
> open-coding it; the resulting code is shorter and less repetitive.
>
> Signed-off-by: René Scharfe <l.s.r@web•de>
> ---
>  builtin/sparse-checkout.c | 10 ++--------
>  dir.c                     | 13 +++----------
>  merge-recursive.c         | 11 +++--------
>  3 files changed, 8 insertions(+), 26 deletions(-)

I love this kind of "now we have this thing available, let's use it
at more places" clean-up patch.

Was coccinelle involved in finding these places?

Thanks.

next prev parent reply	other threads:[~2021-07-30 19:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 19:06 [PATCH] use fspathhash() everywhere René Scharfe
2021-07-30 19:27 ` Junio C Hamano [this message]
2021-07-30 20:22   ` René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq35rv1u2a.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=e@80x24$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=l.s.r@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox